fix not finding contact sensor

Author: Jurgen Heine

api.js

@@ -3,14 +3,14 @@ module.exports = {
             try {
                 homey.app.log("Connect from settings received.");
                 await homey.app.connectToTuyaApi();
-                if(homey.app.logger.lastConnectionError!=null){
-                    return homey.app.logger.lastConnectionError;
-                }
-                return null;
             } catch (err) {
                 homey.app.log(err);
                 return err;
             }
+            if(homey.app.logger.lastConnectionError!=null){
+                throw new Error(homey.app.logger.lastConnectionError);
+            }
+            return null;
         },
 
     async refreshScenes({ homey, query }) {

drivers/tuyacontact/driver.js

@@ -14,7 +14,7 @@ class TuyaCoverDriver extends TuyaBaseDriver {
             throw new Error("Please configure the app first.");
         }
         else {
-            let covers = this.get_devices_by_type("smokeSensor");
+            let covers = this.get_devices_by_type("contactSensor");
             for (let tuyaDevice of Object.values(covers)) {
                 let capabilities = [];
                 capabilities.push("alarm_contact");

lib/tuyashopenapi.js

@@ -46,15 +46,21 @@ class TuyaSHOpenAPI {
             'password': md5pwd,
             'schema': this.appSchema
         });
-        let { access_token, refresh_token, uid, expire_time, platform_url } = res.result;
-        this.endpoint = platform_url ? platform_url : this.endpoint;
-        this.tokenInfo = {
-            access_token: access_token,
-            refresh_token: refresh_token,
-            uid: uid,
-            expire: expire_time * 1000 + new Date().getTime(),
-        };
-
+        if(res.success){
+            let { access_token, refresh_token, uid, expire_time, platform_url } = res.result;
+            this.endpoint = platform_url ? platform_url : this.endpoint;
+            this.tokenInfo = {
+                access_token: access_token,
+                refresh_token: refresh_token,
+                uid: uid,
+                expire: expire_time * 1000 + new Date().getTime(),
+            };
+            this.log.lastConnectionError =null;
+        }else{
+            let msg = "Code: "+res.code+"; msg: "+ res.msg;
+            this.log.lastConnectionError = msg;
+            throw new Error(msg);
+        }
         return;
     }
 
@@ -168,7 +174,7 @@ class TuyaSHOpenAPI {
             this.log.logConnectionError(e);
             return;
         }
-        this.log.lastConnectionError = null;
+        
 
         let now = new Date().getTime();
         let access_token = this.tokenInfo.access_token || '';

locales/nl.json

@@ -1,8 +1,8 @@
 {
   "settings": {
     "apiToUse": "Kies de gewenste API(s)",
-    "appid": "Official api acces id",
-    "appsecret": "Official api acces secret, voor meer informatie: ",
+    "appid": "Official api acces id, voor meer informatie: ",
+    "appsecret": "Official api acces secret",
     "username": "Gebruikersnaam",
     "title": "Tuya cloud instellingen",
     "authentication": "Authenticatie instellingen",

settings/index.html

@@ -36,7 +36,8 @@ <h1><span data-i18n="settings.title"></h1>
             <input id="password" type="password" value="" />
         </div>
         <div class="field row">
-            <label for="appid"><span data-i18n="settings.appid"><a target="_blank" href="https://community.homey.app/t/app-pro-tuya-cloud/21313">https://community.homey.app/t/app-pro-tuya-cloud/21313</a></label>
+            <label for="appid"><span data-i18n="settings.appid"></span></label>
+            <label for="appid"></label><a target="_blank" href="https://community.homey.app/t/app-pro-tuya-cloud/21313">https://community.homey.app/t/app-pro-tuya-cloud/21313</a></label>
             <input id="appid" type="text" value="" />
         </div>
         <div class="field row">

util/logutil.js

@@ -14,13 +14,6 @@ class LogUtil {
     log(...args) {
         this.logfunction(...args);
     }
-
-    logConnectionError(...args) {
-        if(args.length > 0){
-            this.lastConnectionError = args.join(';');
-        }
-        this.logfunction(...args);
-    }
 }
 
 module.exports = LogUtil;