kebab case urls (and matching view templates), add legacy redirects

Author: benjaminapetersen

app/scripts/app.js

@@ -93,8 +93,8 @@ angular
         templateUrl: 'views/projects.html',
         controller: 'ProjectsController'
       })
-      .when('/createProject', {
-        templateUrl: 'views/createProject.html',
+      .when('/create-project', {
+        templateUrl: 'views/create-project.html',
         controller: 'CreateProjectController'
       })
       .when('/project/:project', {
@@ -216,12 +216,12 @@ angular
         templateUrl: 'views/browse/route.html',
         controller: 'RouteController'
       })
-      .when('/project/:project/createRoute', {
-        templateUrl: 'views/createRoute.html',
+      .when('/project/:project/create-route', {
+        templateUrl: 'views/create-route.html',
         controller: 'CreateRouteController'
       })
-      .when('/project/:project/attachPVC', {
-        templateUrl: 'views/attachPVC.html',
+      .when('/project/:project/attach-pvc', {
+        templateUrl: 'views/attach-pvc.html',
         controller: 'AttachPVCController'
       })
       .when('/project/:project/create', {
@@ -237,7 +237,7 @@ angular
         controller: 'CreateFromImageController'
       })
       .when('/project/:project/create/next', {
-        templateUrl: 'views/create/nextSteps.html',
+        templateUrl: 'views/create/next-steps.html',
         controller: 'NextStepsController'
       })
       .when('/project/:project/set-limits', {
@@ -260,7 +260,16 @@ angular
         templateUrl: 'views/util/logout.html',
         controller: 'LogoutController'
       })
-
+      // legacy redirects
+      .when('/createProject', {
+        redirectTo: '/create-project'
+      })
+      .when('/project/:project/createRoute', {
+        redirectTo: '/project/:project/create-route'
+      })
+      .when('/project/:project/attachPVC', {
+        redirectTo: '/project/:project/attach-pvc'
+      })
       .otherwise({
         redirectTo: '/'
       });

app/views/attachPVC.html renamed to app/views/attach-pvc.html

@@ -69,6 +69,6 @@
     builds="builds"
     detailed="true"></pod-template>
     <h4 style="margin-top: 20px;">Volumes</h4>
-    <a ng-href="project/{{project.metadata.name}}/attachPVC?deployment={{deployment.metadata.name}}">Attach storage</a>
+    <a ng-href="project/{{project.metadata.name}}/attach-pvc?deployment={{deployment.metadata.name}}">Attach storage</a>
     <volumes volumes="deployment.spec.template.spec.volumes" namespace="project.metadata.name"></volumes>
 </div>

app/views/browse/_deployment-details.html

@@ -49,10 +49,10 @@ <h3>Template</h3>
       </pod-template>
       <div ng-if="pod.spec.volumes.length">
         <h4 style="margin-top: 20px;">Volumes</h4>
-        <a ng-if="pod | annotation:'deploymentConfig'" ng-href="project/{{project.metadata.name}}/attachPVC?deploymentconfig={{pod | annotation:'deploymentConfig'}}">Attach storage and redeploy</a>
+        <a ng-if="pod | annotation:'deploymentConfig'" ng-href="project/{{project.metadata.name}}/attach-pvc?deploymentconfig={{pod | annotation:'deploymentConfig'}}">Attach storage and redeploy</a>
         <volumes volumes="pod.spec.volumes" namespace="project.metadata.name"></volumes>
       </div>
     </div>
   </div>
   <annotations annotations="pod.metadata.annotations"></annotations>
-</div>
+</div>

app/views/browse/_pod-details.html

@@ -109,7 +109,7 @@ <h3>Template</h3>
                                   detailed="true"></pod-template>
                           </dl>
                           <h4 style="margin-top: 20px;">Volumes</h4>
-                          <a ng-href="project/{{project.metadata.name}}/attachPVC?deploymentconfig={{deploymentConfig.metadata.name}}">Attach storage</a>
+                          <a ng-href="project/{{project.metadata.name}}/attach-pvc?deploymentconfig={{deploymentConfig.metadata.name}}">Attach storage</a>
                           <volumes volumes="deploymentConfig.spec.template.spec.volumes" namespace="project.metadata.name"></volumes>
                         </div>
                         <div class="col-lg-6">

app/views/browse/deployment-config.html

@@ -8,7 +8,7 @@
         <div class="container-fluid">
           <div class="page-header page-header-bleed-right page-header-bleed-left">
             <div class="actions pull-right">
-              <a ng-href="project/{{project.metadata.name}}/createRoute" class="btn btn-default">Create Route</a>
+              <a ng-href="project/{{project.metadata.name}}/create-route" class="btn btn-default">Create Route</a>
             </div>
             <h1>Routes</h1>
           </div>

app/views/browse/routes.html

@@ -104,7 +104,7 @@ <h1>
                     </dd>
                   </dl>
                   <div class="gutter-bottom">
-                    <a ng-href="project/{{project.metadata.name}}/createRoute?service={{service.metadata.name}}">Create route</a>
+                    <a ng-href="project/{{project.metadata.name}}/create-route?service={{service.metadata.name}}">Create route</a>
                   </div>
                   <annotations annotations="service.metadata.annotations"></annotations>
                 </div>

app/views/browse/service.html

@@ -138,7 +138,7 @@ <h2 ng-if="!displayRouteByService[serviceId]">
                           </span>
                         </span>
                         <div ng-if="!displayRouteByService[serviceId]" class="component-label add-route-link">
-                          <a ng-href="project/{{project.metadata.name}}/createRoute?service={{service.metadata.name}}">Create Route</a>
+                          <a ng-href="project/{{project.metadata.name}}/create-route?service={{service.metadata.name}}">Create Route</a>
                         </div>
                       </div>
                     </div>

app/views/createProject.html renamed to app/views/create-project.html

@@ -13,7 +13,7 @@
             <div ng-if="(projects | hashSize) === 0" class="text-muted" style="margin-top: 50px;">Loading...</div>
             <div ng-if="(projects | hashSize) !== 0" class="gutter-top">
               <h1 style="display: inline-block;">Projects</h1>
-              <a ng-if="canCreate" href="createProject" style="margin-top: 10px;" class="btn btn-lg btn-primary pull-right">New Project</a>
+              <a ng-if="canCreate" href="create-project" style="margin-top: 10px;" class="btn btn-lg btn-primary pull-right">New Project</a>
               <alerts alerts="alerts"></alerts>
               <div ng-repeat="project in projects | orderByDisplayName">
                 <div row flex cross-axis="center" class="tile tile-project tile-click tile-flex">
@@ -59,7 +59,7 @@ <h1>Welcome to OpenShift.</h1>
               <span ng-if="canCreate">Create a project for your application.</span>
             </p>
 
-            <a ng-if="canCreate" href="createProject" class="btn btn-lg btn-primary">New Project</a>
+            <a ng-if="canCreate" href="create-project" class="btn btn-lg btn-primary">New Project</a>
 
             <p>To learn more, visit the OpenShift <a ng-href="{{'' | helpLink}}">documentation</a>.</p>
 

app/views/createRoute.html renamed to app/views/create-route.html

@@ -14,7 +14,7 @@ var goToAddToProjectPage = function(projectName) {
 };
 
 var goToCreateProjectPage = function() {
-  h.goToPage('/createProject');
+  h.goToPage('/create-project');
   expect(element(by.cssContainingText('h1', "New Project")).isPresent()).toBe(true);
   expect(element(by.model('name')).isPresent()).toBe(true);
   expect(element(by.model('displayName')).isPresent()).toBe(true);
@@ -186,7 +186,7 @@ describe('', function() {
           element(by.model('name')).clear().sendKeys(project['name']);
           element(by.buttonText("Create")).click();
           expect(element(by.css("[ng-if=nameTaken]")).isDisplayed()).toBe(true);
-          expect(browser.getCurrentUrl()).toMatch(/\/createProject$/);
+          expect(browser.getCurrentUrl()).toMatch(/\/create-project$/);
         });
 
         it('should delete a project', function() {