Polish for Exception message punctuation cleanup.

Closes spring-projects#2603.

Author: jxblum

src/main/java/org/springframework/data/auditing/AnnotationAuditingMetadata.java

@@ -78,7 +78,7 @@ final class AnnotationAuditingMetadata {
 	 */
 	private AnnotationAuditingMetadata(Class<?> type) {
 
-		Assert.notNull(type, "Given type must not be null!");
+		Assert.notNull(type, "Given type must not be null");
 
 		this.createdByField = Optional.ofNullable(ReflectionUtils.findField(type, CREATED_BY_FILTER));
 		this.createdDateField = Optional.ofNullable(ReflectionUtils.findField(type, CREATED_DATE_FILTER));

src/main/java/org/springframework/data/auditing/AuditingHandler.java

@@ -48,7 +48,7 @@ public class AuditingHandler extends AuditingHandlerSupport implements Initializ
 	public AuditingHandler(PersistentEntities entities) {
 
 		super(entities);
-		Assert.notNull(entities, "PersistentEntities must not be null!");
+		Assert.notNull(entities, "PersistentEntities must not be null");
 
 		this.auditorAware = Optional.empty();
 	}
@@ -60,7 +60,7 @@ public AuditingHandler(PersistentEntities entities) {
 	 */
 	public void setAuditorAware(AuditorAware<?> auditorAware) {
 
-		Assert.notNull(auditorAware, "AuditorAware must not be null!");
+		Assert.notNull(auditorAware, "AuditorAware must not be null");
 		this.auditorAware = Optional.of(auditorAware);
 	}
 
@@ -71,7 +71,7 @@ public void setAuditorAware(AuditorAware<?> auditorAware) {
 	 */
 	public <T> T markCreated(T source) {
 
-		Assert.notNull(source, "Entity must not be null!");
+		Assert.notNull(source, "Entity must not be null");
 
 		return markCreated(getAuditor(), source);
 	}
@@ -83,7 +83,7 @@ public <T> T markCreated(T source) {
 	 */
 	public <T> T markModified(T source) {
 
-		Assert.notNull(source, "Entity must not be null!");
+		Assert.notNull(source, "Entity must not be null");
 
 		return markModified(getAuditor(), source);
 	}
@@ -97,7 +97,7 @@ Auditor<?> getAuditor() {
 	public void afterPropertiesSet() {
 
 		if (!auditorAware.isPresent()) {
-			logger.debug("No AuditorAware set! Auditing will not be applied!");
+			logger.debug("No AuditorAware set; Auditing will not be applied");
 		}
 	}
 }

src/main/java/org/springframework/data/auditing/AuditingHandlerSupport.java

@@ -53,7 +53,7 @@ public abstract class AuditingHandlerSupport {
 	 */
 	public AuditingHandlerSupport(PersistentEntities entities) {
 
-		Assert.notNull(entities, "PersistentEntities must not be null!");
+		Assert.notNull(entities, "PersistentEntities must not be null");
 
 		this.factory = new MappingAuditableBeanWrapperFactory(entities);
 	}
@@ -96,7 +96,7 @@ public void setDateTimeProvider(@Nullable DateTimeProvider dateTimeProvider) {
 	 */
 	protected final boolean isAuditable(Object source) {
 
-		Assert.notNull(source, "Source entity must not be null!");
+		Assert.notNull(source, "Source entity must not be null");
 
 		return factory.getBeanWrapperFor(source).isPresent();
 	}
@@ -109,7 +109,7 @@ protected final boolean isAuditable(Object source) {
 	 */
 	<T> T markCreated(Auditor<?> auditor, T source) {
 
-		Assert.notNull(source, "Source entity must not be null!");
+		Assert.notNull(source, "Source entity must not be null");
 
 		return touch(auditor, source, true);
 	}
@@ -122,7 +122,7 @@ <T> T markCreated(Auditor<?> auditor, T source) {
 	 */
 	<T> T markModified(Auditor<?> auditor, T source) {
 
-		Assert.notNull(source, "Source entity must not be null!");
+		Assert.notNull(source, "Source entity must not be null");
 
 		return touch(auditor, source, false);
 	}
@@ -163,7 +163,7 @@ private void touchAuditor(Auditor<?> auditor, AuditableBeanWrapper<?> wrapper, b
 			return;
 		}
 
-		Assert.notNull(wrapper, "AuditableBeanWrapper must not be null!");
+		Assert.notNull(wrapper, "AuditableBeanWrapper must not be null");
 
 		if (isNew) {
 			wrapper.setCreatedBy(auditor.getValue());
@@ -183,11 +183,11 @@ private void touchAuditor(Auditor<?> auditor, AuditableBeanWrapper<?> wrapper, b
 	 */
 	private Optional<TemporalAccessor> touchDate(AuditableBeanWrapper<?> wrapper, boolean isNew) {
 
-		Assert.notNull(wrapper, "AuditableBeanWrapper must not be null!");
+		Assert.notNull(wrapper, "AuditableBeanWrapper must not be null");
 
 		Optional<TemporalAccessor> now = dateTimeProvider.getNow();
 
-		Assert.notNull(now, () -> String.format("Now must not be null! Returned by: %s!", dateTimeProvider.getClass()));
+		Assert.notNull(now, () -> String.format("Now must not be null Returned by: %s", dateTimeProvider.getClass()));
 
 		now.filter(__ -> isNew).ifPresent(wrapper::setCreatedDate);
 		now.filter(__ -> !isNew || modifyOnCreation).ifPresent(wrapper::setLastModifiedDate);

src/main/java/org/springframework/data/auditing/DefaultAuditableBeanWrapperFactory.java

@@ -68,7 +68,7 @@ ConversionService getConversionService() {
 	@SuppressWarnings("unchecked")
 	public <T> Optional<AuditableBeanWrapper<T>> getBeanWrapperFor(T source) {
 
-		Assert.notNull(source, "Source must not be null!");
+		Assert.notNull(source, "Source must not be null");
 
 		return Optional.of(source).map(it -> {
 
@@ -188,7 +188,7 @@ protected Object getDateValueToSet(TemporalAccessor value, Class<?> targetType,
 
 				if (!conversionService.canConvert(value.getClass(), Date.class)) {
 					throw new IllegalArgumentException(
-							String.format("Cannot convert date type for member %s! From %s to java.util.Date to %s", source,
+							String.format("Cannot convert date type for member %s; From %s to java.util.Date to %s", source,
 									value.getClass(), targetType));
 				}
 
@@ -228,7 +228,7 @@ protected <S extends TemporalAccessor> Optional<S> getAsTemporalAccessor(Optiona
 	}
 
 	private static IllegalArgumentException rejectUnsupportedType(Object source) {
-		return new IllegalArgumentException(String.format("Invalid date type %s for member %s! Supported types are %s",
+		return new IllegalArgumentException(String.format("Invalid date type %s for member %s; Supported types are %s",
 				source.getClass(), source, AnnotationAuditingMetadata.SUPPORTED_DATE_TYPES));
 	}
 
@@ -251,7 +251,7 @@ static class ReflectionAuditingBeanWrapper<T> extends DateConvertingAuditableBea
 		public ReflectionAuditingBeanWrapper(ConversionService conversionService, T target) {
 			super(conversionService);
 
-			Assert.notNull(target, "Target object must not be null!");
+			Assert.notNull(target, "Target object must not be null");
 
 			this.metadata = AnnotationAuditingMetadata.getMetadata(target.getClass());
 			this.target = target;

src/main/java/org/springframework/data/auditing/IsNewAwareAuditingHandler.java

@@ -56,7 +56,7 @@ public IsNewAwareAuditingHandler(PersistentEntities entities) {
 	 */
 	public Object markAudited(Object object) {
 
-		Assert.notNull(object, "Source object must not be null!");
+		Assert.notNull(object, "Source object must not be null");
 
 		if (!isAuditable(object)) {
 			return object;

src/main/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactory.java

@@ -64,7 +64,7 @@ public class MappingAuditableBeanWrapperFactory extends DefaultAuditableBeanWrap
 	 */
 	public MappingAuditableBeanWrapperFactory(PersistentEntities entities) {
 
-		Assert.notNull(entities, "PersistentEntities must not be null!");
+		Assert.notNull(entities, "PersistentEntities must not be null");
 
 		this.entities = entities;
 		this.metadataCache = new ConcurrentReferenceHashMap<>();
@@ -118,7 +118,7 @@ static class MappingAuditingMetadata {
 		 */
 		public <P> MappingAuditingMetadata(MappingContext<?, ? extends PersistentProperty<?>> context, Class<?> type) {
 
-			Assert.notNull(type, "Type must not be null!");
+			Assert.notNull(type, "Type must not be null");
 
 			this.createdByPaths = findPropertyPaths(type, CreatedBy.class, context);
 			this.createdDatePaths = findPropertyPaths(type, CreatedDate.class, context);
@@ -184,8 +184,8 @@ public MappingMetadataAuditableBeanWrapper(
 				MappingAuditingMetadata metadata) {
 			super(conversionService);
 
-			Assert.notNull(accessor, "PersistentPropertyAccessor must not be null!");
-			Assert.notNull(metadata, "Auditing metadata must not be null!");
+			Assert.notNull(accessor, "PersistentPropertyAccessor must not be null");
+			Assert.notNull(metadata, "Auditing metadata must not be null");
 
 			this.accessor = accessor;
 			this.metadata = metadata;

src/main/java/org/springframework/data/auditing/ReactiveAuditingHandler.java

@@ -49,7 +49,7 @@ public ReactiveAuditingHandler(PersistentEntities entities) {
 	 */
 	public void setAuditorAware(ReactiveAuditorAware<?> auditorAware) {
 
-		Assert.notNull(auditorAware, "AuditorAware must not be null!");
+		Assert.notNull(auditorAware, "AuditorAware must not be null");
 		this.auditorAware = auditorAware;
 	}
 
@@ -60,7 +60,7 @@ public void setAuditorAware(ReactiveAuditorAware<?> auditorAware) {
 	 */
 	public <T> Mono<T> markCreated(T source) {
 
-		Assert.notNull(source, "Entity must not be null!");
+		Assert.notNull(source, "Entity must not be null");
 
 		return getAuditor() //
 				.map(auditor -> markCreated(auditor, source));
@@ -73,7 +73,7 @@ public <T> Mono<T> markCreated(T source) {
 	 */
 	public <T> Mono<T> markModified(T source) {
 
-		Assert.notNull(source, "Entity must not be null!");
+		Assert.notNull(source, "Entity must not be null");
 
 		return getAuditor() //
 				.map(auditor -> markModified(auditor, source));

src/main/java/org/springframework/data/auditing/ReactiveIsNewAwareAuditingHandler.java

@@ -56,7 +56,7 @@ public ReactiveIsNewAwareAuditingHandler(PersistentEntities entities) {
 	 */
 	public Mono<Object> markAudited(Object object) {
 
-		Assert.notNull(object, "Source object must not be null!");
+		Assert.notNull(object, "Source object must not be null");
 
 		if (!isAuditable(object)) {
 			return Mono.just(object);

src/main/java/org/springframework/data/auditing/config/AnnotationAuditingConfiguration.java

@@ -31,7 +31,7 @@
  */
 public class AnnotationAuditingConfiguration implements AuditingConfiguration {
 
-	private static final String MISSING_ANNOTATION_ATTRIBUTES = "Couldn't find annotation attributes for %s in %s!";
+	private static final String MISSING_ANNOTATION_ATTRIBUTES = "Couldn't find annotation attributes for %s in %s";
 
 	private final AnnotationAttributes attributes;
 
@@ -44,8 +44,8 @@ public class AnnotationAuditingConfiguration implements AuditingConfiguration {
 	 */
 	public AnnotationAuditingConfiguration(AnnotationMetadata metadata, Class<? extends Annotation> annotation) {
 
-		Assert.notNull(metadata, "AnnotationMetadata must not be null!");
-		Assert.notNull(annotation, "Annotation must not be null!");
+		Assert.notNull(metadata, "AnnotationMetadata must not be null");
+		Assert.notNull(annotation, "Annotation must not be null");
 
 		Map<String, Object> attributesSource = metadata.getAnnotationAttributes(annotation.getName());
 

src/main/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupport.java

@@ -53,8 +53,8 @@ public abstract class AuditingBeanDefinitionRegistrarSupport implements ImportBe
 	@Override
 	public void registerBeanDefinitions(AnnotationMetadata annotationMetadata, BeanDefinitionRegistry registry) {
 
-		Assert.notNull(annotationMetadata, "AnnotationMetadata must not be null!");
-		Assert.notNull(registry, "BeanDefinitionRegistry must not be null!");
+		Assert.notNull(annotationMetadata, "AnnotationMetadata must not be null");
+		Assert.notNull(registry, "BeanDefinitionRegistry must not be null");
 
 		AbstractBeanDefinition ahbd = registerAuditHandlerBeanDefinition(registry, getConfiguration(annotationMetadata));
 		registerAuditListenerBeanDefinition(ahbd, registry);
@@ -70,8 +70,8 @@ public void registerBeanDefinitions(AnnotationMetadata annotationMetadata, BeanD
 	private AbstractBeanDefinition registerAuditHandlerBeanDefinition(BeanDefinitionRegistry registry,
 			AuditingConfiguration configuration) {
 
-		Assert.notNull(registry, "BeanDefinitionRegistry must not be null!");
-		Assert.notNull(configuration, "AuditingConfiguration must not be null!");
+		Assert.notNull(registry, "BeanDefinitionRegistry must not be null");
+		Assert.notNull(configuration, "AuditingConfiguration must not be null");
 
 		AbstractBeanDefinition ahbd = getAuditHandlerBeanDefinitionBuilder(configuration).getBeanDefinition();
 		registry.registerBeanDefinition(getAuditingHandlerBeanName(), ahbd);
@@ -87,7 +87,7 @@ private AbstractBeanDefinition registerAuditHandlerBeanDefinition(BeanDefinition
 	 */
 	protected BeanDefinitionBuilder getAuditHandlerBeanDefinitionBuilder(AuditingConfiguration configuration) {
 
-		Assert.notNull(configuration, "AuditingConfiguration must not be null!");
+		Assert.notNull(configuration, "AuditingConfiguration must not be null");
 
 		return configureDefaultAuditHandlerAttributes(configuration,
 				BeanDefinitionBuilder.rootBeanDefinition(AuditingHandler.class));

src/main/java/org/springframework/data/auditing/config/AuditingHandlerBeanDefinitionParser.java

@@ -56,7 +56,7 @@ public class AuditingHandlerBeanDefinitionParser extends AbstractSingleBeanDefin
 	@SuppressWarnings("null")
 	public AuditingHandlerBeanDefinitionParser(String mappingContextBeanName) {
 
-		Assert.hasText(mappingContextBeanName, "MappingContext bean name must not be null!");
+		Assert.hasText(mappingContextBeanName, "MappingContext bean name must not be null");
 		this.mappingContextBeanName = mappingContextBeanName;
 	}
 

src/main/java/org/springframework/data/config/BeanComponentDefinitionBuilder.java

@@ -44,8 +44,8 @@ public class BeanComponentDefinitionBuilder {
 	 */
 	public BeanComponentDefinitionBuilder(Element defaultSource, ParserContext context) {
 
-		Assert.notNull(defaultSource, "DefaultSource must not be null!");
-		Assert.notNull(context, "Context must not be null!");
+		Assert.notNull(defaultSource, "DefaultSource must not be null");
+		Assert.notNull(context, "Context must not be null");
 
 		this.defaultSource = defaultSource;
 		this.context = context;
@@ -59,7 +59,7 @@ public BeanComponentDefinitionBuilder(Element defaultSource, ParserContext conte
 	 */
 	public BeanComponentDefinition getComponent(BeanDefinitionBuilder builder) {
 
-		Assert.notNull(builder, "Builder must not be null!");
+		Assert.notNull(builder, "Builder must not be null");
 
 		AbstractBeanDefinition definition = builder.getRawBeanDefinition();
 		String name = BeanDefinitionReaderUtils.generateBeanName(definition, context.getRegistry(), context.isNested());
@@ -77,7 +77,7 @@ public BeanComponentDefinition getComponent(BeanDefinitionBuilder builder) {
 	 */
 	public BeanComponentDefinition getComponentIdButFallback(BeanDefinitionBuilder builder, String fallback) {
 
-		Assert.hasText(fallback, "Fallback component id must not be null or empty!");
+		Assert.hasText(fallback, "Fallback component id must not be null or empty");
 
 		String id = defaultSource.getAttribute("id");
 		return getComponent(builder, StringUtils.hasText(id) ? id : fallback);
@@ -105,8 +105,8 @@ public BeanComponentDefinition getComponent(BeanDefinitionBuilder builder, Strin
 	 */
 	public BeanComponentDefinition getComponent(BeanDefinitionBuilder builder, String name, Object rawSource) {
 
-		Assert.notNull(builder, "Builder must not be null!");
-		Assert.hasText(name, "Name of bean must not be null or empty!");
+		Assert.notNull(builder, "Builder must not be null");
+		Assert.hasText(name, "Name of bean must not be null or empty");
 
 		AbstractBeanDefinition definition = builder.getRawBeanDefinition();
 		definition.setSource(context.extractSource(rawSource));

src/main/java/org/springframework/data/config/ConfigurationUtils.java

@@ -40,7 +40,7 @@ public interface ConfigurationUtils {
 	 */
 	public static ResourceLoader getRequiredResourceLoader(XmlReaderContext context) {
 
-		Assert.notNull(context, "XmlReaderContext must not be null!");
+		Assert.notNull(context, "XmlReaderContext must not be null");
 
 		ResourceLoader resourceLoader = context.getResourceLoader();
 
@@ -71,7 +71,7 @@ public static ClassLoader getRequiredClassLoader(XmlReaderContext context) {
 	 */
 	public static ClassLoader getRequiredClassLoader(ResourceLoader resourceLoader) {
 
-		Assert.notNull(resourceLoader, "ResourceLoader must not be null!");
+		Assert.notNull(resourceLoader, "ResourceLoader must not be null");
 
 		ClassLoader classLoader = resourceLoader.getClassLoader();
 
@@ -91,7 +91,7 @@ public static ClassLoader getRequiredClassLoader(ResourceLoader resourceLoader)
 	 */
 	public static String getRequiredBeanClassName(BeanDefinition beanDefinition) {
 
-		Assert.notNull(beanDefinition, "BeanDefinition must not be null!");
+		Assert.notNull(beanDefinition, "BeanDefinition must not be null");
 
 		String result = beanDefinition.getBeanClassName();