validate_formats now defaults to true

This reflects new understandings of how "$vocabulary": [ <vocab uri>: false ]
should work, as discussed in
json-schema-org/json-schema-spec#1020 (comment)

Author: karenetheridge

Changes

@@ -1,6 +1,8 @@
 Revision history for JSON-Schema-Draft201909
 
 {{$NEXT}}
+          - the default value for "validate_formats" is now true, to reflect
+            the most typical usecase.
 
 0.019     2020-12-08 18:40:10Z
           - further improvements to the "terse" output format

lib/JSON/Schema/Draft201909.pm

@@ -54,7 +54,7 @@ has max_traversal_depth => (
 has validate_formats => (
   is => 'ro',
   isa => Bool,
-  default => 0, # as specified by https://json-schema.org/draft/2019-09/schema#/$vocabulary
+  default => 1,
 );
 
 has collect_annotations => (
@@ -569,8 +569,10 @@ other, or badly-written schemas that could be optimized. Defaults to 50.
 
 =head2 validate_formats
 
-When true, the C<format> keyword will be treated as an assertion, not merely an annotation. Defaults
-to false.
+When false, the C<format> keyword will be treated as an annotation only (that is, no evaluation
+failure will result if the format of the data string is not as specified). When true, the C<format>
+keyword will be treated as an assertion, where failure is possible.
+Defaults to true.
 
 =head2 format_validations
 

lib/JSON/Schema/Draft201909/Vocabulary/Format.pm

@@ -111,12 +111,15 @@ has _format_validations => (
         fc(Mojo::URL->new($_[0])->to_unsafe_string) eq fc($_[0]) && $_[0] !~ /[^[:ascii:]]/;
       },
       iri => sub { Mojo::URL->new($_[0])->is_abs },
-      'iri-reference' => sub { 1 },
       uuid => sub { $_[0] =~ /^[[:xdigit:]]{8}-(?:[[:xdigit:]]{4}-){3}[[:xdigit:]]{12}$/ },
-      'uri-template' => sub { 1 },
       'json-pointer' => sub { (!length($_[0]) || $_[0] =~ m{^/}) && $_[0] !~ m{~(?![01])} },
       'relative-json-pointer' => sub { $_[0] =~ m{^[0-9]+(?:#$|$|/)} && $_[0] !~ m{~(?![01])} },
       regex => sub { eval { qr/$_[0]/; 1 ? 1 : 0 } },
+
+      # TODO: if the metaschema's $vocabulary entry is true, then we must die on
+      # encountering these unimplemented formats.
+      'iri-reference' => sub { 1 },
+      'uri-template' => sub { 1 },
     };
 
     # the subrefs from JSON::Schema::Draft201909->new(format_evaluations => { ... })
@@ -140,8 +143,6 @@ sub _traverse_keyword_format {
 sub _eval_keyword_format {
   my ($self, $data, $schema, $state) = @_;
 
-  # TODO: instead of checking 'validate_formats', we should be referring to the metaschema's entry
-  # for $vocabulary: { <format url>: <bool> }
   if ($state->{validate_formats}
       and my $spec = $self->_get_format_validation($schema->{format})) {
     return E($state, 'not a%s %s', $schema->{format} =~ /^[aeio]/ ? 'n' : '', $schema->{format})

t/additional-tests.t

@@ -15,7 +15,7 @@ my $accepter = Test::JSON::Schema::Acceptance->new(test_dir => 't/additional-tes
 
 plan skip_all => 'no tests in this directory to test' if not @{$accepter->_test_data};
 
-my %options = (validate_formats => 1);
+my %options = ();
 my $js = JSON::Schema::Draft201909->new(%options);
 my $js_short_circuit = JSON::Schema::Draft201909->new(%options, short_circuit => 1);
 my $encoder = JSON::MaybeXS->new(allow_nonref => 1, utf8 => 0, convert_blessed => 1, canonical => 1, pretty => 1);

t/formats.t

@@ -11,11 +11,12 @@ use Test::Deep;
 use Test::Fatal;
 use JSON::Schema::Draft201909;
 
+my ($annotation_result, $validation_result);
 subtest 'no validation' => sub {
   cmp_deeply(
     JSON::Schema::Draft201909->new(collect_annotations => 1, validate_formats => 0)
       ->evaluate('abc', { format => 'uuid' })->TO_JSON,
-    my $result = {
+    $annotation_result = {
       valid => bool(1),
       annotations => [
         {
@@ -31,7 +32,7 @@ subtest 'no validation' => sub {
   cmp_deeply(
     JSON::Schema::Draft201909->new(collect_annotations => 1, validate_formats => 1)
       ->evaluate('abc', { format => 'uuid' }, { validate_formats => 0 })->TO_JSON,
-    $result,
+    $annotation_result,
     'format validation can be turned off in evaluate()',
   );
 };
@@ -41,16 +42,7 @@ subtest 'simple validation' => sub {
 
   cmp_deeply(
     $js->evaluate(123, { format => 'uuid' })->TO_JSON,
-    {
-      valid => bool(1),
-      annotations => [
-        {
-          instanceLocation => '',
-          keywordLocation => '/format',
-          annotation => 'uuid',
-        },
-      ],
-    },
+    $annotation_result,
     'non-string values are valid, and produce an annotation',
   );
 
@@ -59,22 +51,13 @@ subtest 'simple validation' => sub {
       '2eb8aa08-aa98-11ea-b4aa-73b441d16380',
       { format => 'uuid' },
     )->TO_JSON,
-    {
-      valid => bool(1),
-      annotations => [
-        {
-          instanceLocation => '',
-          keywordLocation => '/format',
-          annotation => 'uuid',
-        },
-      ],
-    },
+    $annotation_result,
     'simple success',
   );
 
   cmp_deeply(
     $js->evaluate('123', { format => 'uuid' })->TO_JSON,
-    my $result = {
+    $validation_result = {
       valid => bool(0),
       errors => [
         {
@@ -88,14 +71,14 @@ subtest 'simple validation' => sub {
   );
 
   $js = JSON::Schema::Draft201909->new(collect_annotations => 1);
-  ok(!$js->validate_formats, 'format_validation defaults to false');
+  ok($js->validate_formats, 'format_validation defaults to true');
   cmp_deeply(
-    $js->evaluate('123', { format => 'uuid' }, { validate_formats => 1 })->TO_JSON,
-    $result,
-    'format validation can be turned on in evaluate()',
+    $js->evaluate('123', { format => 'uuid' }, { validate_formats => 0 })->TO_JSON,
+    $annotation_result,
+    'format validation can be turned off in evaluate()',
   );
 
-  ok(!$js->validate_formats, '...but the value is still false on the object');
+  ok($js->validate_formats, '...but the value is still true on the object');
 };
 
 subtest 'unknown format attribute' => sub {

t/zzz-acceptance.t

@@ -34,7 +34,7 @@ my $accepter = Test::JSON::Schema::Acceptance->new(
   verbose => 1,
 );
 
-my %options = (validate_formats => 1);
+my %options = ();
 my $js = JSON::Schema::Draft201909->new(%options);
 my $js_short_circuit = JSON::Schema::Draft201909->new(%options, short_circuit => 1);