You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move packaging scripts from swiftwasm-package-sdk (#18)
Currently our CI scripts rely on validity of scripts in the [`swiftwasm-package-sdk`](https://github.com/swiftwasm/swiftwasm-package-sdk) repository. That can't always be the case, especialy as we don't checkout a specific commit in that repository. And even if we did, managing this isn't convenient. Adding a submodule has its own set of issues and I personally think that a monorepo approach is much simpler for a small set of scripts, at least at an early stage. In fact, it would make sense to have these scripts in the upstream [`swift`](https://github.com/apple/swift) repository at some point, similarly to [what Android people have previously done](https://github.com/apple/swift/tree/master/utils/android).
Thus, these scripts and a few small helper files are copied to `utils/webassembly` directory and are executed directly on CI.
After this PR is merged, I don't see a particular need for our [`swiftwasm-package-sdk`](https://github.com/swiftwasm/swiftwasm-package-sdk) and [`swiftwasm-sdk`](https://github.com/swiftwasm/swiftwasm-sdk) repos, those probably can be archived.
As a small cleanup addition, `.github/workflows/main.yml` file now has consistent indentation.
* Move packaging scripts from swiftwasm-package-sdk
* Rename `wasm` directory to `webassembly`
* Make all .sh scripts executable after download
* Make sdkroot/swiftwasm script executable
* Add newline to build-mac-package.sh
* Add newline to build-packages.sh
* Remove swift_start.o and swift_end.o
0 commit comments