remove the null_data_source (cattle-ops#332)

Author: kayman-mk

main.tf

@@ -159,7 +159,7 @@ resource "aws_autoscaling_group" "gitlab_runner_instance" {
   health_check_grace_period = 0
   launch_configuration      = aws_launch_configuration.gitlab_runner_instance.name
   enabled_metrics           = var.metrics_autoscaling
-  tags                      = data.null_data_source.agent_tags.*.outputs
+  tags                      = [for key, value in local.agent_tags : tomap({ "key" : key, "value" : value, "propagate_at_launch" : true })]
 }
 
 resource "aws_autoscaling_schedule" "scale_in" {

tags.tf

@@ -28,23 +28,3 @@ locals {
     for key in keys(var.runner_tags) : [key, lookup(var.runner_tags, key)]
   ]))
 }
-
-data "null_data_source" "tags" {
-  count = length(local.tags)
-
-  inputs = {
-    key                 = element(keys(local.tags), count.index)
-    value               = element(values(local.tags), count.index)
-    propagate_at_launch = "true"
-  }
-}
-
-data "null_data_source" "agent_tags" {
-  count = length(local.agent_tags)
-
-  inputs = {
-    key                 = element(keys(local.agent_tags), count.index)
-    value               = element(values(local.agent_tags), count.index)
-    propagate_at_launch = "true"
-  }
-}