Skip to content

Commit e5cb3d0

Browse files
committed
🆙 update: rule name
1 parent 09ee649 commit e5cb3d0

13 files changed

+23
-23
lines changed

Diff for: README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ See [here](https://kazupon.github.io/eslint-plugin-vue-i18n/)
1616
Details changes for each release are documented in the [CHANGELOG.md](https://github.com/kazupon/eslint-plugin-vue-i18n/blob/master/CHANGELOG.md).
1717

1818
## :white_check_mark: TODO
19-
- [x] no-missing-key
20-
- [ ] no-dynamic-key
21-
- [x] no-unused-key
19+
- [x] no-missing-keys
20+
- [ ] no-dynamic-keys
21+
- [x] no-unused-keys
2222
- [ ] no-raw-text
2323
- [ ] valid-message-syntax
2424
- [ ] keys-order

Diff for: docs/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ For example:
2626
],
2727
"rules": {
2828
// Optional.
29-
"vue-i18n/no-dynamic-key": "error"
29+
"vue-i18n/no-dynamic-keys": "error"
3030
},
3131
"settings": {
3232
"vue-i18n": {

Diff for: docs/rules/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
| Rule ID | Description | |
99
|:--------|:------------|:---|
10-
| [vue-i18n/<wbr>no-missing-key](./no-missing-key.html) | disallow missing locale message key at localization methods | :star: |
10+
| [vue-i18n/<wbr>no-missing-keys](./no-missing-keys.html) | disallow missing locale message key at localization methods | :star: |
1111

1212
## Best Practices
1313

1414
| Rule ID | Description | |
1515
|:--------|:------------|:---|
16-
| [vue-i18n/<wbr>no-unused-key](./no-unused-key.html) | disallow unused localization keys | |
16+
| [vue-i18n/<wbr>no-unused-keys](./no-unused-keys.html) | disallow unused localization keys | |
1717

Diff for: docs/rules/no-missing-key.md renamed to docs/rules/no-missing-keys.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# vue-i18n/no-missing-key
1+
# vue-i18n/no-missing-keys
22

33
> disallow missing locale message key at localization methods
44

Diff for: docs/rules/no-unused-key.md renamed to docs/rules/no-unused-keys.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# vue-i18n/no-unused-key
1+
# vue-i18n/no-unused-keys
22

33
> disallow unused localization keys
44
@@ -78,7 +78,7 @@ You can specify allowed directive-comments.
7878

7979
```json
8080
{
81-
"vue-i18n/no-unused-key": ["error", {
81+
"vue-i18n/no-unused-keys": ["error", {
8282
"extensions": [".js", ".vue"]
8383
}]
8484
}

Diff for: lib/configs/recommended.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
module.exports = {
55
plugins: ['vue-i18n'],
66
rules: {
7-
'vue-i18n/no-missing-key': 'error'
7+
'vue-i18n/no-missing-keys': 'error'
88
}
99
}

Diff for: lib/processors/json.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = {
1818
postprocess ([errors], filename) {
1919
delete localeMessageFiles[filename]
2020
return [...errors.filter(
21-
error => !error.ruleId || error.ruleId === 'vue-i18n/no-unused-key'
21+
error => !error.ruleId || error.ruleId === 'vue-i18n/no-unused-keys'
2222
)]
2323
},
2424

Diff for: lib/rules.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
'use strict'
33

44
module.exports = {
5-
'no-missing-key': require('./rules/no-missing-key'),
6-
'no-unused-key': require('./rules/no-unused-key')
5+
'no-missing-keys': require('./rules/no-missing-keys'),
6+
'no-unused-keys': require('./rules/no-unused-keys')
77
}
File renamed without changes.

Diff for: lib/rules/no-unused-key.js renamed to lib/rules/no-unused-keys.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const jsonDiffPatch = require('jsondiffpatch').create({})
99
const flatten = require('flat')
1010
const collectKeys = require('../utils/collect-keys')
1111
const { loadLocaleMessages } = require('../utils/index')
12-
const debug = require('debug')('eslint-plugin-vue-i18n:no-unused-key')
12+
const debug = require('debug')('eslint-plugin-vue-i18n:no-unused-keys')
1313

1414
let usedLocaleMessageKeys = null // used locale message keys
1515
let localeMessages = null // used locale messages
@@ -59,7 +59,7 @@ function traverseNode (fullpath, paths, ast, fn) {
5959
function create (context) {
6060
const filename = context.getFilename()
6161
if (extname(filename) !== '.json') {
62-
debug(`ignore ${filename} in no-unused-key`)
62+
debug(`ignore ${filename} in no-unused-keys`)
6363
return {}
6464
}
6565

@@ -72,7 +72,7 @@ function create (context) {
7272

7373
const targetLocaleMessage = findExistLocaleMessage(filename, localeMessages)
7474
if (!targetLocaleMessage) {
75-
debug(`ignore ${filename} in no-unused-key`)
75+
debug(`ignore ${filename} in no-unused-keys`)
7676
return {}
7777
}
7878

Diff for: lib/utils/collect-keys.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const { defineTemplateBodyVisitor } = require('./index')
1111
const { listFilesToProcess } = require('./glob-utils')
1212
const debug = require('debug')('eslint-plugin-vue-i18n:collect-keys')
1313

14-
const INTERNAL_RULE_KEY = 'eslint-plugin-vue-i18n-internal-localization-key'
14+
const INTERNAL_RULE_KEY = 'eslint-plugin-vue-i18n-internal-localization-keys'
1515

1616
function getKeyFromCallExpression (node) {
1717
const funcName = (node.callee.type === 'MemberExpression' && node.callee.property.name) || node.callee.name

Diff for: tests/lib/rules/no-missing-key.js renamed to tests/lib/rules/no-missing-keys.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
'use strict'
55

66
const RuleTester = require('eslint').RuleTester
7-
const rule = require('../../../lib/rules/no-missing-key')
7+
const rule = require('../../../lib/rules/no-missing-keys')
88

99
const baseDir = './tests/fixtures/locales'
1010
const resolve = file => `${baseDir}/${file}`
@@ -20,7 +20,7 @@ const tester = new RuleTester({
2020
parserOptions: { ecmaVersion: 2015 }
2121
})
2222

23-
tester.run('no-missing-key', rule, {
23+
tester.run('no-missing-keys', rule, {
2424
valid: [{
2525
// basic key
2626
settings,

Diff for: tests/lib/rules/no-unused-key.js renamed to tests/lib/rules/no-unused-keys.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ const linter = new CLIEngine({
2424
},
2525
plugins: ['vue-i18n'],
2626
rules: {
27-
'vue-i18n/no-unused-key': 'error'
27+
'vue-i18n/no-unused-keys': 'error'
2828
},
2929
useEslintrc: true,
3030
extensions: ['.js', '.vue', '.json']
3131
})
3232

33-
describe('no-unused-key', () => {
33+
describe('no-unused-keys', () => {
3434
let originalCwd
3535
const resolveFilename = Module._resolveFilename
3636

@@ -57,13 +57,13 @@ describe('no-unused-key', () => {
5757
const [enResult] = messages.results
5858
.filter(result => result.filePath === enFullPath)
5959
enResult.messages.forEach(message => {
60-
assert.equal(message.ruleId, 'vue-i18n/no-unused-key')
60+
assert.equal(message.ruleId, 'vue-i18n/no-unused-keys')
6161
})
6262
const jaFullPath = resolve(__dirname, '../../fixtures/locales/ja.json')
6363
const [jaResult] = messages.results
6464
.filter(result => result.filePath === jaFullPath)
6565
jaResult.messages.forEach(message => {
66-
assert.equal(message.ruleId, 'vue-i18n/no-unused-key')
66+
assert.equal(message.ruleId, 'vue-i18n/no-unused-keys')
6767
})
6868
})
6969
})

0 commit comments

Comments
 (0)