Fix testing for up to date tooling & apply new linting fixes.

Author: kemra102

Diff for: LICENSE

@@ -0,0 +1,5 @@
+Copyright (c) 2018 Danny Roberts, All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Diff for: Makefile

@@ -3,16 +3,16 @@ default : check kitchen
 check : rubocop foodcritic
 
 rubocop :
-	/opt/chefdk/bin/rubocop .
+	/opt/chefdk/embedded/bin/rubocop .
 
 foodcritic :
-	/opt/chefdk/bin/foodcritic -P -f any .
+	/opt/chefdk/embedded/bin/foodcritic -P -f any .
 
 travis : check
 	kitchen verify
 
 kitchen :
-	/opt/chefdk/bin/kitchen test
+	/opt/chefdk/embedded/bin/kitchen test
 
 .PHONY:
 	rubocop foodcritic kitchen

Diff for: libraries/helper.rb

@@ -17,7 +17,7 @@ def self.create_device_passphrase(passphrase, device)
 
     def self.encrypted?(device)
       shell_out!("[ $(file --dereference --special-files #{device} | cut -d\' \' -f3) == \'encrypted\' ]") # rubocop:disable Metrics/LineLength
-    rescue
+    rescue StandardError
       false
     end
   end

Diff for: metadata.rb

@@ -8,7 +8,7 @@
 
 chef_version '>= 12.5' if respond_to?(:chef_version)
 
-%w(centos oracle redhat scientific).each do |os|
+%w[centos oracle redhat scientific].each do |os|
   supports os, '>= 7.0'
 end
 supports 'ubuntu', '>= 12.04'

Diff for: recipes/default.rb

@@ -1 +1 @@
-%w(cryptsetup file).each { |pkg| package pkg }
+%w[cryptsetup file].each { |pkg| package pkg }

Diff for: resources/device.rb

@@ -1,6 +1,5 @@
 resource_name :dmcrypt_device
 
-property :name, String, required: true, name_property: true
 property :device, String, required: false
 property :passphrase, String, required: false
 property :keyfile, String, required: false