Skip to content

Fix: special characters in id #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2018
Merged

Fix: special characters in id #22

merged 1 commit into from
Apr 11, 2018

Conversation

timdeschryver
Copy link
Member

What: #12

Why: Because with a special character in in id, it wouldn't find the input.

How: Changed the # selector to a [id="xxx"] selector.

Checklist:

  • [N/A] Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

I had a problem during the pre commit hook, so I bypassed it.
See:

25lRunning tasks for README.md [started]
.\node_modules\doctoc\doctoc.js --maxlevel 3 --notitle [started]
.\node_modules\doctoc\doctoc.js --maxlevel 3 --notitle [failed]
→ .\node_modules\doctoc\doctoc.js could not be found. Try `npm install .\node_modules\doctoc\doctoc.js`.
.\node_modules\doctoc\doctoc.js could not be found. Try `npm install .\node_modules\doctoc\doctoc.js`.
Running tasks for README.md [failed]
→ .\node_modules\doctoc\doctoc.js could not be found. Try `npm install .\node_modules\doctoc\doctoc.js`.
25h25h

@timdeschryver timdeschryver changed the title fix: special characters in id Fix: special characters in id Apr 11, 2018
kentcdodds
kentcdodds approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous! Thank you!

@kentcdodds kentcdodds merged commit 97af0e6 into testing-library:master Apr 11, 2018
@timdeschryver timdeschryver deleted the pr/id-special-characters branch April 11, 2018 17:35
@kentcdodds
Copy link
Member

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexkrolick alexkrolick mentioned this pull request May 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timdeschryver @kentcdodds