Skip to content

fix(TS): Correct array return types for queryAll and getAll apis #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2018
Merged

fix(TS): Correct array return types for queryAll and getAll apis #60

merged 1 commit into from
Jun 19, 2018

Conversation

wgcrouch
Copy link
Collaborator

@wgcrouch wgcrouch commented Jun 19, 2018 •
edited
Loading

What:
Updated the the return type type definition for the getAll* and queryAll* apis.

Why:
Currently the return type is [HTMLElement] which is an array of 1 element rather than an array of HTMLElements: HTMLElement[]

How:
By updating the .dts file

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

kentcdodds
kentcdodds approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentcdodds kentcdodds merged commit 275496f into testing-library:master Jun 19, 2018
@kentcdodds
Copy link
Member

Thanks!

@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick pushed a commit to alexkrolick/dom-testing-library that referenced this pull request Sep 13, 2018
@ChrisWcs @alexkrolick
docs: add test example for context. (testing-library#60)
3b1255b 
* Add Test and add myself to list of contributors

* Change getByTestId to getByText

* Chage how value is set on Provider because it is better on performance

* Add test to list of examples in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgcrouch @kentcdodds