Rename createGlobalPersistentStoreStub to get...

Author: kimadeline

src/client/pythonEnvironments/base/envsCache.ts

@@ -4,7 +4,7 @@
 import { cloneDeep } from 'lodash';
 import { IFileSystem } from '../../common/platform/types';
 import { IPersistentState } from '../../common/types';
-import { createGlobalPersistentStore } from '../common/externalDependencies';
+import { getGlobalPersistentStore } from '../common/externalDependencies';
 import { areSameEnvironment, PartialPythonEnvironment } from '../info';
 import { PythonEnvInfo } from './info';
 
@@ -68,7 +68,7 @@ export class PythonEnvInfoCache implements IEnvsCache {
         }
 
         this.initialized = true;
-        this.persistentStorage = createGlobalPersistentStore<PythonEnvInfo[]>('PYTHON_ENV_INFO_CACHE');
+        this.persistentStorage = getGlobalPersistentStore<PythonEnvInfo[]>('PYTHON_ENV_INFO_CACHE');
         this.envsList = this.persistentStorage?.value;
     }
 

src/client/pythonEnvironments/common/externalDependencies.ts

@@ -43,7 +43,7 @@ function getPersistentStateFactory(): IPersistentStateFactory {
     return internalServiceContainer.get<IPersistentStateFactory>(IPersistentStateFactory);
 }
 
-export function createGlobalPersistentStore<T>(key: string): IPersistentState<T> {
+export function getGlobalPersistentStore<T>(key: string): IPersistentState<T> {
     const factory = getPersistentStateFactory();
     return factory.createGlobalPersistentState<T>(key, undefined);
 }

src/test/pythonEnvironments/base/envsCache.unit.test.ts

@@ -9,7 +9,7 @@ import * as externalDependencies from '../../../client/pythonEnvironments/common
 import * as envInfo from '../../../client/pythonEnvironments/info';
 
 suite('Environment Info cache', () => {
-    let createGlobalPersistentStoreStub: sinon.SinonStub;
+    let getGlobalPersistentStoreStub: sinon.SinonStub;
     let areSameEnvironmentStub: sinon.SinonStub;
     let updatedValues: PythonEnvInfo[] | undefined;
 
@@ -32,8 +32,8 @@ suite('Environment Info cache', () => {
             (env1: PythonEnvInfo, env2:PythonEnvInfo) => env1.name === env2.name,
         );
 
-        createGlobalPersistentStoreStub = sinon.stub(externalDependencies, 'createGlobalPersistentStore');
-        createGlobalPersistentStoreStub.returns({
+        getGlobalPersistentStoreStub = sinon.stub(externalDependencies, 'getGlobalPersistentStore');
+        getGlobalPersistentStoreStub.returns({
             value: envInfoArray,
             updateValue: async (envs: PythonEnvInfo[]) => {
                 updatedValues = envs;
@@ -43,7 +43,7 @@ suite('Environment Info cache', () => {
     });
 
     teardown(() => {
-        createGlobalPersistentStoreStub.restore();
+        getGlobalPersistentStoreStub.restore();
         areSameEnvironmentStub.restore();
         updatedValues = undefined;
     });
@@ -53,13 +53,13 @@ suite('Environment Info cache', () => {
 
         envsCache.initialize();
 
-        assert.ok(createGlobalPersistentStoreStub.calledOnce);
+        assert.ok(getGlobalPersistentStoreStub.calledOnce);
     });
 
     test('The in-memory env info array is undefined if there is no value in persistent storage when initializing the cache', () => {
         const envsCache = new PythonEnvInfoCache(allEnvsComplete);
 
-        createGlobalPersistentStoreStub.returns({ value: undefined });
+        getGlobalPersistentStoreStub.returns({ value: undefined });
         envsCache.initialize();
         const result = envsCache.getAllEnvs();