REACT_APP_SASS does not generate CSS file

[jbach]

When REACT_APP_SASS=true, the CSS is embedded in the JS file rather than output as a separate CSS file. I guess ExtractTextPlugin.extract is missing for the Sass loader?

[kitze]

This should be only happening in development mode, in production mode when using npm run build the compiled css should be in an extra file because ExtractTextPlugin.extract is configured.

[jbach]

I’ve added a reduced testcase to https://github.com/jbach/custom-react-scripts-sass. Try running npm run build, the css will not be extracted. Am I doing something wrong? Maybe I’m confused, but looking at config/customizers.js, I don’t see ExtractTextPlugin.extract.

When I manually change the sass-loader in config/customizers.jsto

'SASS': {
    toArray: 'loaders',
    get: function () {
      return {
        test: /\.scss$/,
        loader: ExtractTextPlugin.extract('style', "css!postcss!sass")
      }
    }
  }

a separate CSS file is built.

[kitze]

Just released 0.0.14 with a better fix for this. Now each customizer has a getDev and getProd functions. Should be ok now.

[jbach]

Thank you for the fix, but can you confirm 0.0.14 is installable via npm? Installation via npm i custom-react-scripts fails for me with Node 6.6.0 / npm 3.10.3. See my full npm-debug.log

npm ERR! Path must be a string. Received undefined

[kitze]

Yes. I got the same error with Node v6.6.0. I also see other people [have this issue]with different npm packages (webpack/webpack#2463) but I have no idea why.

Installing the scripts with Node v.6.2.0 worked completely fine for me. Please try it and let me know.

[jbach]

I’ll close this issue. The nonrelated install bug is described in #13