Remove default argument of export_values

Author: kljohann

include/genpybind/annotations/annotations.def

@@ -9,7 +9,7 @@ ANNOTATION_KIND(Visible, visible)    // (Boolean|Default)?
 
 // EnumDecl
 ANNOTATION_KIND(Arithmetic, arithmetic)      // (Boolean)?
-ANNOTATION_KIND(ExportValues, export_values) // (Boolean|Default)?
+ANNOTATION_KIND(ExportValues, export_values) // (Boolean)?
 
 // CXXMethodDecl only (but not CXXConstructorDecl, CXXConversionDecl, CXXDestructorDecl, and operators)
 ANNOTATION_KIND(GetterFor, getter_for) // (String)+

src/annotated_decl.cpp

@@ -380,22 +380,15 @@ bool genpybind::processAnnotation(const clang::NamedDecl *decl,
     return false;
 
   case AnnotationKind::Arithmetic:
-    return dispatch
-        .nullary([&]() { attrs.arithmetic = true; })
-        // TODO: "default"?
+    return dispatch.nullary([&]() { attrs.arithmetic = true; })
         .unary(LiteralValue::Kind::Boolean,
                [&](const LiteralValue &value) {
                  attrs.arithmetic = value.getBoolean();
                })
         .checkMatch();
 
   case AnnotationKind::ExportValues:
-    return dispatch
-        .nullary([&]() { attrs.export_values = true; })
-        // TODO: Remove "default"?
-        .unary(
-            LiteralValue::Kind::Default,
-            [&](const LiteralValue &) { attrs.export_values = std::nullopt; })
+    return dispatch.nullary([&]() { attrs.export_values = true; })
         .unary(LiteralValue::Kind::Boolean,
                [&](const LiteralValue &value) {
                  attrs.export_values = value.getBoolean();
@@ -420,9 +413,7 @@ bool genpybind::processAnnotation(const clang::NamedDecl *decl,
     return false;
 
   case AnnotationKind::DynamicAttr:
-    return dispatch
-        .nullary([&]() { attrs.dynamic_attr = true; })
-        // TODO: "default"?
+    return dispatch.nullary([&]() { attrs.dynamic_attr = true; })
         .unary(LiteralValue::Kind::Boolean,
                [&](const LiteralValue &value) {
                  attrs.dynamic_attr = value.getBoolean();

tests/integration/enums-export-values-when-scoped.h

@@ -10,12 +10,6 @@ enum class GENPYBIND(export_values) ScopedExport {
   ScopedExportC,
 };
 
-enum class GENPYBIND(export_values(default)) ScopedExportDefault {
-  ScopedExportDefaultA,
-  ScopedExportDefaultB,
-  ScopedExportDefaultC,
-};
-
 enum class GENPYBIND(export_values(true)) ScopedExportTrue {
   ScopedExportTrueA,
   ScopedExportTrueB,

tests/integration/enums-export-values-when-scoped_test.py

@@ -9,7 +9,7 @@ def test_values_are_exported():
 
 
 def test_values_are_not_exported():
-    for name in ["Scoped", "ScopedExportDefault", "ScopedExportFalse"]:
+    for name in ["Scoped", "ScopedExportFalse"]:
         enum = getattr(m, name)
         for suffix in ["A", "B", "C"]:
             assert not hasattr(m, f"{name}{suffix}")

tests/integration/enums-export-values-when-unscoped.h

@@ -10,12 +10,6 @@ enum GENPYBIND(export_values) UnscopedExport {
   UnscopedExportC,
 };
 
-enum GENPYBIND(export_values(default)) UnscopedExportDefault {
-  UnscopedExportDefaultA,
-  UnscopedExportDefaultB,
-  UnscopedExportDefaultC,
-};
-
 enum GENPYBIND(export_values(true)) UnscopedExportTrue {
   UnscopedExportTrueA,
   UnscopedExportTrueB,

tests/integration/enums-export-values-when-unscoped_test.py

@@ -5,7 +5,6 @@ def test_values_are_exported():
     for name in [
         "Unscoped",
         "UnscopedExport",
-        "UnscopedExportDefault",
         "UnscopedExportTrue",
     ]:
         enum = getattr(m, name)