Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic should move to the new revision, after the minimum number of pods are ready during the prgressive rollout #302

Closed
houshengbo opened this issue Apr 7, 2025 · 0 comments · Fixed by #303
Closed

Traffic should move to the new revision, after the minimum number of pods are ready during the prgressive rollout #302

houshengbo opened this issue Apr 7, 2025 · 0 comments · Fixed by #303
Assignees
@houshengbo
Labels
enhancement New feature or request

Comments

@houshengbo
Copy link
Contributor

houshengbo commented Apr 7, 2025 •
edited
Loading

As long as the minimum number of pods are ready, we are good to move all the designated traffic percentage over. However, if it does not reach the requirement of minimum number of pods running for each stage during the progressive rollout, we should hold until the pods are ready before moving the traffic percentage.
@houshengbo houshengbo self-assigned this Apr 7, 2025
@houshengbo houshengbo added the enhancement New feature or request label Apr 7, 2025
houshengbo added a commit to houshengbo/serving-progressive-rollout that referenced this issue Apr 7, 2025
@houshengbo
Shift traffic when the minimum number of replicas are ready during pr…
7d170be 
…ogressive rollout

Fixes: knative-extensions#302
@houshengbo houshengbo mentioned this issue Apr 7, 2025
Merged
@knative-prow knative-prow bot closed this as completed in 295c430 Apr 14, 2025
knative-prow-robot pushed a commit to knative-prow-robot/serving-progressive-rollout that referenced this issue Apr 14, 2025
@houshengbo @knative-prow-robot
Shift traffic when the minimum number of replicas are ready during pr…
1021459 
…ogressive rollout

Fixes: knative-extensions#302
knative-prow-robot pushed a commit to knative-prow-robot/serving-progressive-rollout that referenced this issue Apr 14, 2025
@houshengbo @knative-prow-robot
Shift traffic when the minimum number of replicas are ready during pr…
8a3ba38 
…ogressive rollout

Fixes: knative-extensions#302
knative-prow-robot pushed a commit to knative-prow-robot/serving-progressive-rollout that referenced this issue Apr 14, 2025
@houshengbo @knative-prow-robot
Shift traffic when the minimum number of replicas are ready during pr…
7a9fb8a 
…ogressive rollout

Fixes: knative-extensions#302
knative-prow-robot pushed a commit to knative-prow-robot/serving-progressive-rollout that referenced this issue Apr 14, 2025
@houshengbo @knative-prow-robot
Shift traffic when the minimum number of replicas are ready during pr…
6f74399 
…ogressive rollout

Fixes: knative-extensions#302
knative-prow bot pushed a commit that referenced this issue Apr 14, 2025
@knative-prow-robot @houshengbo
[release-1.17] Shift traffic when the minimum number of replicas are …
50b161c 
…ready during progressive rollout (#313)

* Shift traffic when the minimum number of replicas are ready during progressive rollout

Fixes: #302

* Verify if the target replicas is nil

* Added the test cases

* Clean up the logic for the routeLister

* Check the final revision name

---------

Co-authored-by: Vincent Hou <[email protected]>
knative-prow bot pushed a commit that referenced this issue Apr 14, 2025
@knative-prow-robot @houshengbo
[release-1.16] Shift traffic when the minimum number of replicas are …
0d11770 
…ready during progressive rollout (#314)

* Shift traffic when the minimum number of replicas are ready during progressive rollout

Fixes: #302

* Verify if the target replicas is nil

* Added the test cases

* Clean up the logic for the routeLister

* Check the final revision name

---------

Co-authored-by: Vincent Hou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@houshengbo houshengbo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@houshengbo