test: switch tests to jest

Author: jonathanong

.github/workflows/node.js.yml

@@ -23,5 +23,5 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - run: npm ci
     - run: npm run lint
-    - run: npm run test-cov
+    - run: npm test -- --coverage --maxWorkers 2
     - run: npx codecov

test/.eslintrc.yml __tests__/.eslintrc.yml

@@ -1,5 +1,5 @@
 env:
-  mocha: true
+  jest: true
 
 rules:
   space-before-blocks: [2, {functions: never, keywords: always}]

test/application/context.js __tests__/application/context.js

@@ -3,11 +3,8 @@
 
 const assert = require('assert');
 const Koa = require('../..');
-const mm = require('mm');
 
 describe('app.onerror(err)', () => {
-  afterEach(mm.restore);
-
   it('should throw an error if a non-error is given', () => {
     const app = new Koa();
 
@@ -34,21 +31,21 @@ describe('app.onerror(err)', () => {
 
     err.status = 404;
 
-    let called = false;
-    mm(console, 'error', () => { called = true; });
+    const spy = jest.spyOn(console, 'error');
     app.onerror(err);
-    assert(!called);
+    expect(spy).not.toHaveBeenCalled();
+    spy.mockRestore();
   });
 
   it('should do nothing if .silent', () => {
     const app = new Koa();
     app.silent = true;
     const err = new Error();
 
-    let called = false;
-    mm(console, 'error', () => { called = true; });
+    const spy = jest.spyOn(console, 'error');
     app.onerror(err);
-    assert(!called);
+    expect(spy).not.toHaveBeenCalled();
+    spy.mockRestore();
   });
 
   it('should log the error to stderr', () => {
@@ -58,28 +55,9 @@ describe('app.onerror(err)', () => {
     const err = new Error();
     err.stack = 'Foo';
 
-    let msg = '';
-    mm(console, 'error', input => {
-      if (input) msg = input;
-    });
-    app.onerror(err);
-    assert(msg === '\n  Foo\n');
-  });
-
-  it('should use err.toString() instead of err.stack', () => {
-    const app = new Koa();
-    app.env = 'dev';
-
-    const err = new Error('mock stack null');
-    err.stack = null;
-
-    app.onerror(err);
-
-    let msg = '';
-    mm(console, 'error', input => {
-      if (input) msg = input;
-    });
+    const spy = jest.spyOn(console, 'error');
     app.onerror(err);
-    assert(msg === '\n  Error: mock stack null\n');
+    expect(spy).toHaveBeenCalled();
+    spy.mockRestore();
   });
 });

test/application/index.js __tests__/application/index.js

@@ -189,7 +189,7 @@ describe('app.respond', () => {
         .head('/')
         .expect(200);
 
-      assert.strictEqual(res.header['content-length'], length);
+      assert.strictEqual(~~res.header['content-length'], length);
       assert(!res.text);
     });
 

test/application/inspect.js __tests__/application/inspect.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 const assert = require('assert');
 
 describe('ctx.assert(value, status)', () => {

test/application/onerror.js __tests__/application/onerror.js

@@ -4,7 +4,7 @@
 const prototype = require('../../lib/context');
 const assert = require('assert');
 const util = require('util');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.inspect()', () => {
   it('should return a json representation', () => {

test/application/request.js __tests__/application/request.js

@@ -3,7 +3,7 @@
 const assert = require('assert');
 const request = require('supertest');
 const Koa = require('../..');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.onerror(err)', () => {
   it('should respond', () => {
@@ -276,7 +276,7 @@ describe('ctx.onerror(err)', () => {
       const app = new Koa();
 
       app.on('error', err => {
-        assert.strictEqual(err, 'Error: non-error thrown: {"key":"value"}');
+        assert.strictEqual(err.message, 'non-error thrown: {"key":"value"}');
         done();
       });
 

test/application/respond.js __tests__/application/respond.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 const assert = require('assert');
 
 describe('ctx.throw(msg)', () => {

test/application/response.js __tests__/application/response.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.toJSON()', () => {
   it('should return a json representation', () => {

test/application/toJSON.js __tests__/application/toJSON.js

@@ -2,8 +2,8 @@ const assert = require('assert');
 
 let importESM = () => {};
 
-describe('Load with esm', () => {
-  before(function(){
+describe.skip('Load with esm', () => {
+  beforeAll(function(){
     // ESM support is flagged on v12.x.
     const majorVersion = +process.version.split('.')[0].slice(1);
     if (majorVersion < 12) {

test/application/use.js __tests__/application/use.js

@@ -3,7 +3,7 @@
 
 const Accept = require('accepts');
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.accept', () => {
   it('should return an Accept instance', () => {

test/context/assert.js __tests__/context/assert.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.accepts(types)', () => {
   describe('with no arguments', () => {

test/context/cookies.js __tests__/context/cookies.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.acceptsCharsets()', () => {
   describe('with no arguments', () => {

test/context/inspect.js __tests__/context/inspect.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.acceptsEncodings()', () => {
   describe('with no arguments', () => {

test/context/onerror.js __tests__/context/onerror.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.acceptsLanguages(langs)', () => {
   describe('with no arguments', () => {

test/context/state.js __tests__/context/state.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 const assert = require('assert');
 
 describe('req.charset', () => {

test/context/throw.js __tests__/context/throw.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.fresh', () => {
   describe('the request method is not GET and HEAD', () => {

test/context/toJSON.js __tests__/context/toJSON.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.get(name)', () => {
   it('should return the field value', () => {

test/load-with-esm.js __tests__/load-with-esm.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('req.header', () => {
   it('should return the request header object', () => {

test/request/accept.js __tests__/request/accept.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('req.headers', () => {
   it('should return the request header object', () => {

test/request/accepts.js __tests__/request/accepts.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 const assert = require('assert');
 
 describe('req.host', () => {

test/request/acceptsCharsets.js __tests__/request/acceptsCharsets.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 const assert = require('assert');
 
 describe('req.hostname', () => {

test/request/acceptsEncodings.js __tests__/request/acceptsEncodings.js

@@ -5,7 +5,7 @@ const assert = require('assert');
 const Stream = require('stream');
 const http = require('http');
 const Koa = require('../../');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.href', () => {
   it('should return the full request url', () => {

test/request/acceptsLanguages.js __tests__/request/acceptsLanguages.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('ctx.idempotent', () => {
   describe('when the request method is idempotent', () => {

test/request/charset.js __tests__/request/charset.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 const assert = require('assert');
 const util = require('util');
 

test/request/fresh.js __tests__/request/fresh.js

@@ -4,7 +4,7 @@
 const assert = require('assert');
 const Stream = require('stream');
 const Koa = require('../..');
-const Request = require('../helpers/context').request;
+const Request = require('../../test-helpers/context').request;
 
 describe('req.ip', () => {
   describe('with req.ips present', () => {

test/request/get.js __tests__/request/get.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('req.ips', () => {
   describe('when X-Forwarded-For is present', () => {

test/request/header.js __tests__/request/header.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 const assert = require('assert');
 
 describe('ctx.is(type)', () => {

test/request/headers.js __tests__/request/headers.js

@@ -1,7 +1,7 @@
 
 'use strict';
 
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 const assert = require('assert');
 
 describe('ctx.length', () => {

test/request/host.js __tests__/request/host.js

@@ -3,7 +3,7 @@
 
 const assert = require('assert');
 const Stream = require('stream');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.origin', () => {
   it('should return the origin of url', () => {

test/request/hostname.js __tests__/request/hostname.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 const parseurl = require('parseurl');
 
 describe('ctx.path', () => {

test/request/href.js __tests__/request/href.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('req.protocol', () => {
   describe('when encrypted', () => {

test/request/idempotent.js __tests__/request/idempotent.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.query', () => {
   describe('when missing', () => {

test/request/inspect.js __tests__/request/inspect.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 const parseurl = require('parseurl');
 
 describe('ctx.querystring', () => {

test/request/ip.js __tests__/request/ip.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const context = require('../helpers/context');
+const context = require('../../test-helpers/context');
 
 describe('ctx.search=', () => {
   it('should replace the search', () => {

test/request/ips.js __tests__/request/ips.js

@@ -2,7 +2,7 @@
 'use strict';
 
 const assert = require('assert');
-const request = require('../helpers/context').request;
+const request = require('../../test-helpers/context').request;
 
 describe('req.secure', () => {
   it('should return true when encrypted', () => {