Skip to content

Support message for @deprecated directive #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jxnu-liguobin opened this issue Dec 18, 2020 · 2 comments
Closed

Support message for @deprecated directive #445

jxnu-liguobin opened this issue Dec 18, 2020 · 2 comments
Assignees
@jxnu-liguobin
Labels
kotlin Pull requests that update Kotlin code scala Pull requests that update Scala code
Milestone
4.1.0

Comments

@jxnu-liguobin
Copy link
Collaborator

jxnu-liguobin commented Dec 18, 2020 •
edited by kobylynskyi
Loading

Describe the solution you'd like

  • scala.@deprecatedshould be used instead of Java's @Deprecated.
  • Message should be supported in the deprecated directive, especially for Kotlin. This value is required, now we've used a default value for it, but that's not a good way. should be replaced.

It may be necessary to refactor XXDefinition.deprecated. It involves multilingualism, and it is not sure how to isolate it for the time being. After all, Java doesn't support the message field in Deprecated annotation.

And more considerations for default graphql Directive?
@kobylynskyi kobylynskyi added good-first-issue Good for newcomers and removed good-first-issue Good for newcomers labels Dec 19, 2020
@kobylynskyi kobylynskyi added this to the 4.1.0 milestone Dec 29, 2020
@kobylynskyi kobylynskyi changed the title support message for deprecated directive Support message for @deprecated directive Dec 29, 2020
@kobylynskyi kobylynskyi added kotlin Pull requests that update Kotlin code scala Pull requests that update Scala code labels Dec 29, 2020
@kobylynskyi
Copy link
Owner

Will be released in 4.1.0

@kobylynskyi
Copy link
Owner

@jxnu-liguobin thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxnu-liguobin jxnu-liguobin

Labels
kotlin Pull requests that update Kotlin code scala Pull requests that update Scala code
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
2 participants
@kobylynskyi @jxnu-liguobin