Skip to content

Commit 9eb140b

Browse files
committed
Modify the arguments-differ tests for different output messages
This commit modifies the tests for arguments-differ output messages based on different error cases. It is part one of the issue pylint-dev#3536
1 parent 4faf101 commit 9eb140b

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

tests/functional/a/arguments_differ_py3.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
# pylint: disable=missing-docstring,too-few-public-methods
22
class AbstractFoo:
33

4-
def kwonly_1(self, first, *, second, third):
4+
def kwonly_1(self, first: int, *, second: int, third: int):
55
"Normal positional with two positional only params."
66

7-
def kwonly_2(self, *, first, second):
7+
def kwonly_2(self, *, first: str, second: str):
88
"Two positional only parameter."
99

10-
def kwonly_3(self, *, first, second):
10+
def kwonly_3(self, *, first: str, second: str):
1111
"Two positional only params."
1212

13-
def kwonly_4(self, *, first, second=None):
13+
def kwonly_4(self, *, first: str, second=None):
1414
"One positional only and another with a default."
1515

16-
def kwonly_5(self, *, first, **kwargs):
16+
def kwonly_5(self, *, first: bool, **kwargs):
1717
"Keyword only and keyword variadics."
1818

19-
def kwonly_6(self, first, second, *, third):
19+
def kwonly_6(self, first: float, second: float, *, third: int):
2020
"Two positional and one keyword"
2121

2222

2323
class Foo(AbstractFoo):
2424

25-
def kwonly_1(self, first, *, second): # [arguments-differ]
25+
def kwonly_1(self, first: int, *, second: int): # [arguments-differ]
2626
"One positional and only one positional only param."
2727

28-
def kwonly_2(self, first): # [arguments-differ]
28+
def kwonly_2(self, *, first: str): # [arguments-differ]
2929
"Only one positional parameter instead of two positional only parameters."
3030

31-
def kwonly_3(self, first, second): # [arguments-differ]
31+
def kwonly_3(self, **kwargs):
3232
"Two positional params."
3333

34-
def kwonly_4(self, first, second): # [arguments-differ]
34+
def kwonly_4(self, *args): # [arguments-differ]
3535
"Two positional params."
3636

37-
def kwonly_5(self, *, first): # [arguments-differ]
37+
def kwonly_5(self, *, first: bool): # [arguments-differ]
3838
"Keyword only, but no variadics."
3939

4040
def kwonly_6(self, *args, **kwargs): # valid override
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
arguments-differ:25:4:Foo.kwonly_1:Parameters differ from overridden 'kwonly_1' method
2-
arguments-differ:28:4:Foo.kwonly_2:Parameters differ from overridden 'kwonly_2' method
3-
arguments-differ:31:4:Foo.kwonly_3:Parameters differ from overridden 'kwonly_3' method
4-
arguments-differ:34:4:Foo.kwonly_4:Parameters differ from overridden 'kwonly_4' method
5-
arguments-differ:37:4:Foo.kwonly_5:Parameters differ from overridden 'kwonly_5' method
1+
arguments-differ:25:4:Foo.kwonly_1:Number of parameters has changed in overridden 'Foo.kwonly_1' method
2+
arguments-differ:28:4:Foo.kwonly_2:Number of parameters has changed in overridden 'Foo.kwonly_2' method
3+
arguments-differ:34:4:Foo.kwonly_4:Number of parameters has changed in overridden 'Foo.kwonly_4' method
4+
arguments-differ:37:4:Foo.kwonly_5:Variadics removed in overridden 'Foo.kwonly_5' method

0 commit comments

Comments
 (0)