conformances getting there (#5)

Author: ktoso

Diff for: lib/Sema/DerivedConformances.cpp

@@ -494,6 +494,7 @@ DerivedConformance::declareDerivedConstantProperty(Identifier name,
       VarDecl(/*IsStatic*/ isStatic, VarDecl::Introducer::Let,
                            SourceLoc(), name, parentDC);
   propDecl->setImplicit();
+  propDecl->setSynthesized();
   propDecl->copyFormalAccessFrom(Nominal, /*sourceIsParentContext*/ true);
   propDecl->setInterfaceType(propertyInterfaceType);
 

Diff for: lib/Sema/TypeCheckProtocol.cpp

@@ -2708,8 +2708,30 @@ bool ConformanceChecker::checkActorIsolation(
   Type witnessGlobalActor;
   switch (auto witnessRestriction =
               ActorIsolationRestriction::forDeclaration(witness)) {
-  case ActorIsolationRestriction::ActorSelf:
   case ActorIsolationRestriction::DistributedActor: {
+    if (witness->isSynthesized()) {
+      // Some of our synthesized properties get special treatment,
+      // they are always available, regardless if the actor is remote even.
+      auto &C = requirement->getASTContext();
+
+      // actorAddress is special, it is *always* available.
+      // even if the actor is 'remote' it is always available and immutable.
+      if (witness->getName() == C.Id_actorAddress &&
+          witness->getInterfaceType()->isEqual(
+              C.getActorAddressDecl()->getDeclaredInterfaceType()))
+        return false;
+
+      // TODO: we don't *really* need to expose the transport like that... reconsider?
+      if (witness->getName() == C.Id_actorTransport &&
+          witness->getInterfaceType()->isEqual(
+              C.getActorTransportDecl()->getDeclaredInterfaceType()))
+        return false;
+    }
+
+    // continue checking ActorSelf rules
+    LLVM_FALLTHROUGH;
+  }
+  case ActorIsolationRestriction::ActorSelf: {
     // Actor-isolated witnesses cannot conform to protocol requirements.
     witness->diagnose(diag::actor_isolated_witness,
                       witness->getDescriptiveKind(),

Diff for: test/Concurrency/Runtime/distributed_actor_run.swift

@@ -6,30 +6,6 @@
 import Dispatch
 import _Concurrency
 
-protocol DA {
-  @actorIndependent
-  var actorTransport: ActorTransport { get }
-}
-
-actor class XXX: DA {
-  let actorTransport: ActorTransport
-//  @actorIndependent(unsafe) var actorTransport: ActorTransport {
-//    self._actorTransport
-//  }
-  init(transport: ActorTransport) {
-    self.actorTransport = transport
-  }
-}
-
-protocol P {
-  var field: String { get }
-}
-
-actor class P1: P {
-  let field: String = "hello"
-}
-
-
 distributed actor class SomeSpecificDistributedActor {
 //  // @derived let actorTransport: ActorTransport
 //  // @derived let actorAddress: ActorAddress