Skip to content

Commit c7d16dc

Browse files
committed
Use GitHub CLI to release
1 parent 7dfe89b commit c7d16dc

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/release.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
git push https://${{ github.token }}@github.com/${{ github.repository }}.git v${{ github.event.inputs.releaseVersion }}
4141
- name: Publish Release
4242
if: ${{ github.event.inputs.dry-run != 'true' }}
43-
uses: ncipollo/release-action@v1
44-
with:
45-
token: ${{ secrets.GITHUB_TOKEN }}
46-
tag: v${{ github.event.inputs.releaseVersion }}
43+
env:
44+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
45+
run: |
46+
gh release create -d --generate-notes v${{ github.event.inputs.releaseVersion }}

RELEASE.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ Now we are ready to perform the release.
2424

2525
## Release
2626

27-
There are 2 options to release: via Github Action or by manul
27+
There are 2 options to release: via GitHub Action or by manul
2828

29-
### Release via Github Action
29+
### Release via GitHub Action
3030

3131
Maintainers meeting the following requirements will be able to perform automated
3232
release:
@@ -36,21 +36,21 @@ release:
3636

3737
#### Fill in the release workflow inputs manually
3838

39-
The Github Action workflow [Release](https://github.com/kubernetes-client/c/actions/workflows/release.yml) will require three manual inputs:
39+
The GitHub Action workflow [Release](https://github.com/kubernetes-client/c/actions/workflows/release.yml) will require three manual inputs:
4040

4141
* The branch on which the workflow runs, must be a release branch, e.g. `release-X.Y`
4242

4343
* The releasing version, must be a valid semver `X.Y.Z` (without "v" prefix).
4444

45-
* Dry-Run: Indicating whether the release job will push the generated tag to the release branch and actually do a Github release.
45+
* Dry-Run: Indicating whether the release job will push the generated tag to the release branch and actually do a GitHub release.
4646

4747
Fill in the inputs, then click "Run" to start the job.
4848

4949
#### Release note, announcements
5050

51-
After the release job successfully finishes, we're supposed to see a git tag `vX.Y.Z` pushed to the release branch, a GITHUB release will also be packed on the tag.
51+
After the release job successfully finishes, we're supposed to see a git tag `vX.Y.Z` pushed to the release branch, a GitHub draft release will also be packed on the tag.
5252

53-
In the end, don't forget to clarify the release notes on the GITHUB release.
53+
In the end, manually update the release notes and publish the release on the GitHub release page.
5454

5555
### Release by manual
5656

0 commit comments

Comments
 (0)