Revert "fix CA1825"

This reverts commit 17e03bc.

Author: tg123

src/KubernetesClient/CertUtils.cs

@@ -104,7 +104,7 @@ public static X509Certificate2 GeneratePfx(KubernetesClientConfiguration config)
 
             using (var pkcs = new MemoryStream())
             {
-                store.Save(pkcs, Array.Empty<char>(), new SecureRandom());
+                store.Save(pkcs, new char[0], new SecureRandom());
 
                 if (config.ClientCertificateKeyStoreFlags.HasValue)
                 {

src/KubernetesClient/KubeConfigModels/K8SConfiguration.cs

@@ -33,19 +33,19 @@ public class K8SConfiguration
         /// Gets or sets a map of referencable names to context configs.
         /// </summary>
         [YamlMember(Alias = "contexts")]
-        public IEnumerable<Context> Contexts { get; set; } = System.Array.Empty<Context>();
+        public IEnumerable<Context> Contexts { get; set; } = new Context[0];
 
         /// <summary>
         /// Gets or sets a map of referencable names to cluster configs.
         /// </summary>
         [YamlMember(Alias = "clusters")]
-        public IEnumerable<Cluster> Clusters { get; set; } = System.Array.Empty<Cluster>();
+        public IEnumerable<Cluster> Clusters { get; set; } = new Cluster[0];
 
         /// <summary>
         /// Gets or sets a map of referencable names to user configs
         /// </summary>
         [YamlMember(Alias = "users")]
-        public IEnumerable<User> Users { get; set; } = System.Array.Empty<User>();
+        public IEnumerable<User> Users { get; set; } = new User[0];
 
         /// <summary>
         /// Gets or sets additional information. This is useful for extenders so that reads and writes don't clobber unknown fields.

src/KubernetesClient/KubeConfigModels/UserCredentials.cs

@@ -49,7 +49,7 @@ public class UserCredentials
         /// Gets or sets the groups to imperonate.
         /// </summary>
         [YamlMember(Alias = "as-groups", ApplyNamingConventions = false)]
-        public IEnumerable<string> ImpersonateGroups { get; set; } = System.Array.Empty<string>();
+        public IEnumerable<string> ImpersonateGroups { get; set; } = new string[0];
 
         /// <summary>
         /// Gets or sets additional information for impersonated user.

tests/KubernetesClient.Tests/AuthTests.cs

@@ -396,7 +396,7 @@ public void Token()
         private X509Certificate2 OpenCertificateStore(Stream stream)
         {
             Pkcs12Store store = new Pkcs12Store();
-            store.Load(stream, Array.Empty<char>());
+            store.Load(stream, new char[] { });
 
             var keyAlias = store.Aliases.Cast<string>().SingleOrDefault(a => store.IsKeyEntry(a));
 
@@ -441,7 +441,7 @@ private K8SConfiguration GetK8SConfiguration(string serverUri, string token, str
                     command = "printf";
                 }
 
-                var arguments = Array.Empty<string>();
+                var arguments = new string[] { };
                 if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
                 {
                     arguments = $"/c echo {responseJson}".Split(" ");

tests/KubernetesClient.Tests/Kubernetes.Exec.Tests.cs

@@ -190,7 +190,7 @@ public async Task NamespacedPodExecAsync_ActionNull()
                 muxedStream.Setup(m => m.GetStream(ChannelIndex.Error, null)).Returns(errorStream);
 
                 var kubernetesMock = new Moq.Mock<Kubernetes>(
-                    new object[] { Moq.Mock.Of<ServiceClientCredentials>(), Array.Empty<DelegatingHandler>() });
+                    new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
                 var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
 
                 kubernetesMock.Setup(m => m.MuxedStreamNamespacedPodExecAsync("pod-name", "pod-namespace", command,
@@ -211,7 +211,7 @@ await Assert.ThrowsAsync<ArgumentNullException>(() => client.NamespacedPodExecAs
         public async Task NamespacedPodExecAsync_HttpException_WithStatus()
         {
             var kubernetesMock = new Moq.Mock<Kubernetes>(
-                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), Array.Empty<DelegatingHandler>() });
+                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
             var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
             var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
 
@@ -234,7 +234,7 @@ public async Task NamespacedPodExecAsync_HttpException_WithStatus()
         public async Task NamespacedPodExecAsync_HttpException_NoStatus()
         {
             var kubernetesMock = new Moq.Mock<Kubernetes>(
-                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), Array.Empty<DelegatingHandler>() });
+                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
             var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
             var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
 
@@ -257,7 +257,7 @@ public async Task NamespacedPodExecAsync_HttpException_NoStatus()
         public async Task NamespacedPodExecAsync_GenericException()
         {
             var kubernetesMock = new Moq.Mock<Kubernetes>(
-                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), Array.Empty<DelegatingHandler>() });
+                new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
             var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
             var handler = new ExecAsyncCallback((stdIn, stdOut, stdError) => Task.CompletedTask);
 
@@ -309,7 +309,7 @@ public async Task NamespacedPodExecAsync_ExitCode_NonZero()
                 muxedStream.Setup(m => m.GetStream(ChannelIndex.Error, null)).Returns(errorStream);
 
                 var kubernetesMock = new Moq.Mock<Kubernetes>(
-                    new object[] { Moq.Mock.Of<ServiceClientCredentials>(), Array.Empty<DelegatingHandler>() });
+                    new object[] { Moq.Mock.Of<ServiceClientCredentials>(), new DelegatingHandler[] { } });
                 var command = new string[] { "/bin/bash", "-c", "echo Hello, World!" };
 
                 var exception = new Exception();

tests/KubernetesClient.Tests/Mock/MockWebSocket.cs

@@ -60,7 +60,7 @@ public override Task CloseAsync(WebSocketCloseStatus closeStatus, string statusD
             this.closeStatusDescription = statusDescription;
             this.receiveBuffers.Enqueue(new MessageData()
             {
-                Buffer = new ArraySegment<byte>(Array.Empty<byte>()),
+                Buffer = new ArraySegment<byte>(new byte[] { }),
                 EndOfMessage = true,
                 MessageType = WebSocketMessageType.Close,
             });