fix SA1211

Author: tg123

src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs

@@ -333,7 +333,7 @@ private void SetUserDetails(K8SConfiguration k8SConfig, Context activeContext)
                                 var config = userDetails.UserCredentials.AuthProvider.Config;
                                 if (config.ContainsKey("expires-on"))
                                 {
-                                    var expiresOn = Int32.Parse(config["expires-on"]);
+                                    var expiresOn = int.Parse(config["expires-on"]);
                                     DateTimeOffset expires;
 #if NET452
                                     var epoch = new DateTimeOffset(1970, 1, 1, 0, 0, 0, TimeSpan.Zero);

src/KubernetesClient/KubernetesClientConfiguration.InCluster.cs

@@ -16,7 +16,7 @@ public partial class KubernetesClientConfiguration
         private const string ServiceAccountTokenKeyFileName = "token";
         private const string ServiceAccountRootCAKeyFileName = "ca.crt";
 
-        public static Boolean IsInCluster()
+        public static bool IsInCluster()
         {
             var host = Environment.GetEnvironmentVariable("KUBERNETES_SERVICE_HOST");
             var port = Environment.GetEnvironmentVariable("KUBERNETES_SERVICE_PORT");

src/KubernetesClient/Yaml.cs

@@ -22,7 +22,7 @@ public class ByteArrayStringYamlConverter : IYamlTypeConverter
         {
             public bool Accepts(Type type)
             {
-                return type == typeof(System.Byte[]);
+                return type == typeof(byte[]);
             }
 
             public object ReadYaml(IParser parser, Type type)
@@ -49,7 +49,7 @@ public object ReadYaml(IParser parser, Type type)
 
             public void WriteYaml(IEmitter emitter, object value, Type type)
             {
-                var obj = (System.Byte[])value;
+                var obj = (byte[])value;
                 emitter.Emit(new YamlDotNet.Core.Events.Scalar(Encoding.UTF8.GetString(obj)));
             }
         }
@@ -63,7 +63,7 @@ public void WriteYaml(IEmitter emitter, object value, Type type)
         /// <param name="typeMap">
         /// A map from <apiVersion>/<kind> to Type. For example "v1/Pod" -> typeof(V1Pod)
         /// </param>
-        public static async Task<List<object>> LoadAllFromStreamAsync(Stream stream, Dictionary<String, Type> typeMap)
+        public static async Task<List<object>> LoadAllFromStreamAsync(Stream stream, Dictionary<string, Type> typeMap)
         {
             var reader = new StreamReader(stream);
             var content = await reader.ReadToEndAsync().ConfigureAwait(false);
@@ -79,7 +79,7 @@ public static async Task<List<object>> LoadAllFromStreamAsync(Stream stream, Dic
         /// <param name="typeMap">
         /// A map from <apiVersion>/<kind> to Type. For example "v1/Pod" -> typeof(V1Pod)
         /// </param>
-        public static Task<List<object>> LoadAllFromFileAsync(String fileName, Dictionary<String, Type> typeMap)
+        public static Task<List<object>> LoadAllFromFileAsync(string fileName, Dictionary<string, Type> typeMap)
         {
             var reader = File.OpenRead(fileName);
             return LoadAllFromStreamAsync(reader, typeMap);
@@ -94,7 +94,7 @@ public static Task<List<object>> LoadAllFromFileAsync(String fileName, Dictionar
         /// <param name="typeMap">
         /// A map from <apiVersion>/<kind> to Type. For example "v1/Pod" -> typeof(V1Pod)
         /// </param>
-        public static List<object> LoadAllFromString(String content, Dictionary<String, Type> typeMap)
+        public static List<object> LoadAllFromString(string content, Dictionary<string, Type> typeMap)
         {
             var deserializer =
                 new DeserializerBuilder()
@@ -221,7 +221,7 @@ private IPropertyDescriptor TrimPropertySuffix(IPropertyDescriptor pd, Type type
                 // This might have been renamed by AutoRest.  See if there is a
                 // JsonPropertyAttribute.PropertyName and use that instead if there is.
                 var jpa = pd.GetCustomAttribute<JsonPropertyAttribute>();
-                if (jpa == null || String.IsNullOrEmpty(jpa.PropertyName))
+                if (jpa == null || string.IsNullOrEmpty(jpa.PropertyName))
                 {
                     return pd;
                 }

tests/KubernetesClient.Tests/Logging/TestOutputLogger.cs

@@ -30,7 +30,7 @@ public TestOutputLogger(ITestOutputHelper testOutput, string loggerCategory, Log
                 throw new ArgumentNullException(nameof(testOutput));
             }
 
-            if (String.IsNullOrWhiteSpace(loggerCategory))
+            if (string.IsNullOrWhiteSpace(loggerCategory))
             {
                 throw new ArgumentException(
                     "Argument cannot be null, empty, or entirely composed of whitespace: 'loggerCategory'.",
@@ -83,7 +83,7 @@ public void Log<TState>(LogLevel level, EventId eventId, TState state, Exception
                 throw new ArgumentNullException(nameof(formatter));
             }
 
-            TestOutput.WriteLine(String.Format("[{0}] {1}: {2}",
+            TestOutput.WriteLine(string.Format("[{0}] {1}: {2}",
                 level,
                 LoggerCategory,
                 formatter(state, exception)));

tests/KubernetesClient.Tests/YamlTests.cs

@@ -23,7 +23,7 @@ public void LoadAllFromString()
 metadata:
   name: ns";
 
-            var types = new Dictionary<String, Type>();
+            var types = new Dictionary<string, Type>();
             types.Add("v1/Pod", typeof(V1Pod));
             types.Add("v1/Namespace", typeof(V1Namespace));