Skip to content

Websocket POST vs GET #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbohlool opened this issue Jun 16, 2017 · 1 comment
Closed

Websocket POST vs GET #30

mbohlool opened this issue Jun 16, 2017 · 1 comment

Comments

@mbohlool
Copy link
Contributor

mbohlool commented Jun 16, 2017

Created this issue to continue the discussion in #19

TODO(mehdy): add a summary of discussion here.

I've digged a little more and found the issue that resulted in adding POST: kubernetes/kubernetes#10366

I've also looked at kubernetes code, and GET and POST serving paths look the same (as far as I can tell).

The argument in kubernetes/kubernetes#10366 could be applied to SPDY or http/2 but not websocket. I think we should be fine with websocket GET only as the serving path is the same and there is no plan to remove GET from exec/attach/portforward serving stack in kubernetes.

Another solution for java client is to support SPDY/HTTP2 instead of websocket (we supported websocket for python client because there were no good SPDY client for python). This way we are not bounded by websocket limitation of GET.

cc: @brendandburns

@brendandburns
Copy link
Contributor

Closing this, because we've conclusively gone with WebSockets and GET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants