Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Commit 3ea8003

Browse files
authored
Merge pull request #198 from ACXLM/fix/load-kube-config
fix cfg is none, load kube config error
2 parents 70d6639 + 30d9e2a commit 3ea8003

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

Diff for: config/kube_config.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -663,9 +663,8 @@ def load_config(self, path):
663663
for item in ('clusters', 'contexts', 'users'):
664664
config_merged[item] = []
665665
self.config_merged = ConfigNode(path, config_merged, path)
666-
667666
for item in ('clusters', 'contexts', 'users'):
668-
self._merge(item, config.get(item, {}), path)
667+
self._merge(item, config.get(item, []) or [], path)
669668
self.config_files[path] = config
670669

671670
def _merge(self, item, add_cfg, path):

Diff for: config/kube_config_test.py

+23-2
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,7 @@ def test__get_kube_config_loader_for_yaml_file_persist(self):
13531353
actual = _get_kube_config_loader_for_yaml_file(config_file,
13541354
persist_config=True)
13551355
self.assertTrue(callable(actual._config_persister))
1356-
self.assertEquals(actual._config_persister.__name__, "save_changes")
1356+
self.assertEqual(actual._config_persister.__name__, "save_changes")
13571357

13581358
def test__get_kube_config_loader_file_no_persist(self):
13591359
expected = FakeConfig(host=TEST_HOST,
@@ -1553,6 +1553,26 @@ class TestKubeConfigMerger(BaseTestCase):
15531553
}
15541554
]
15551555
}
1556+
TEST_KUBE_CONFIG_PART6 = {
1557+
"current-context": "no_user",
1558+
"contexts": [
1559+
{
1560+
"name": "no_user",
1561+
"context": {
1562+
"cluster": "default"
1563+
}
1564+
},
1565+
],
1566+
"clusters": [
1567+
{
1568+
"name": "default",
1569+
"cluster": {
1570+
"server": TEST_HOST
1571+
}
1572+
},
1573+
],
1574+
"users": None
1575+
}
15561576

15571577
def _create_multi_config(self):
15581578
files = []
@@ -1561,7 +1581,8 @@ def _create_multi_config(self):
15611581
self.TEST_KUBE_CONFIG_PART2,
15621582
self.TEST_KUBE_CONFIG_PART3,
15631583
self.TEST_KUBE_CONFIG_PART4,
1564-
self.TEST_KUBE_CONFIG_PART5):
1584+
self.TEST_KUBE_CONFIG_PART5,
1585+
self.TEST_KUBE_CONFIG_PART6):
15651586
files.append(self._create_temp_file(yaml.safe_dump(part)))
15661587
return ENV_KUBECONFIG_PATH_SEPARATOR.join(files)
15671588

0 commit comments

Comments
 (0)