Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Commit 4b9da57

Browse files
author
Vladimir Jigulin
committed
Improve similarity with kubelet in handling of oidc kubeconfigs
- allow 'client-secret' to be empty - fix 'verify' parameter of refresh_token call
1 parent 95858d5 commit 4b9da57

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Diff for: config/kube_config.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,14 @@ def _refresh_oidc(self, provider):
361361
return
362362

363363
response = json.loads(response.data)
364+
client_secret = provider['config'].safe_get('client-secret') or ''
364365

365366
request = OAuth2Session(
366367
client_id=provider['config']['client-id'],
367368
token=provider['config']['refresh-token'],
368369
auto_refresh_kwargs={
369370
'client_id': provider['config']['client-id'],
370-
'client_secret': provider['config']['client-secret']
371+
'client_secret': client_secret
371372
},
372373
auto_refresh_url=response['token_endpoint']
373374
)
@@ -377,7 +378,7 @@ def _refresh_oidc(self, provider):
377378
token_url=response['token_endpoint'],
378379
refresh_token=provider['config']['refresh-token'],
379380
auth=(provider['config']['client-id'],
380-
provider['config']['client-secret']),
381+
client_secret),
381382
verify=config.ssl_ca_cert if config.verify_ssl else None
382383
)
383384
except oauthlib.oauth2.rfc6749.errors.InvalidClientIdError:

0 commit comments

Comments
 (0)