Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

ReplicationController delete propagation policy #242

Closed
hedrox opened this issue Jun 21, 2021 · 1 comment · Fixed by #244
Closed

ReplicationController delete propagation policy #242

hedrox opened this issue Jun 21, 2021 · 1 comment · Fixed by #244
Assignees

Comments

@hedrox
Copy link
Contributor

hedrox commented Jun 21, 2021

When running the function test_replication_controller_apis from dynamic/test_client.py, the test deletes the replication controller, but not the underlying pods. I think this happens because by default the replication controller orphans the pods when deleted, and a solution could be to set the propagation policy to background or foreground.

If you want I can submit a PR here and then also in kubernetes-client/python, because there are replication controller tests in there that suffer from the same issue.

@roycaihw
Copy link
Member

Thanks for reporting! I didn't expect the default behavior to be orphan the pods :( It would be awesome if you could open PRs in the repos to fix those tests.

/assign @hedrox

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants