Merge pull request #146 from c3y1huang/c3y1/fix/NodePublishVolume-does-not-return-err

k8s-ci-robot · web-flow · commit 8963fb3c030b · 2020-02-13T01:22:35.000-08:00
Return error when NodePublishVolume mount fails
diff --git a/pkg/hostpath/nodeserver.go b/pkg/hostpath/nodeserver.go
@@ -181,6 +181,7 @@ func (ns *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis
 					errList.WriteString(fmt.Sprintf(" :%s", rmErr.Error()))
 				}
 			}
+			return nil, status.Error(codes.Internal, fmt.Sprintf("failed to mount device: %s at %s: %s", path, targetPath, errList.String()))
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,7 @@ func (ns nodeServer) NodePublishVolume(ctx context.Context, req csi.NodePublis`
`181`	`181`	`errList.WriteString(fmt.Sprintf(" :%s", rmErr.Error()))`
`182`	`182`	`}`
`183`	`183`	`}`
	`184`	`+ return nil, status.Error(codes.Internal, fmt.Sprintf("failed to mount device: %s at %s: %s", path, targetPath, errList.String()))`
`184`	`185`	`}`
`185`	`186`	`}`
`186`	`187`