Merge pull request #238 from antmoveh/master

k8s-ci-robot · web-flow · commit 2c0449e1f5f8 · 2021-10-18T00:03:49.000-07:00
Reset directory permissions
diff --git a/pkg/nfs/controllerserver.go b/pkg/nfs/controllerserver.go
@@ -104,6 +104,10 @@ func (cs *ControllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
 	if err = os.Mkdir(internalVolumePath, 0777); err != nil && !os.IsExist(err) {
 		return nil, status.Errorf(codes.Internal, "failed to make subdirectory: %v", err.Error())
 	}
+	// Reset directory permissions because of umask problems
+	if err = os.Chmod(internalVolumePath, 0777); err != nil {
+		klog.Warningf("failed to chmod subdirectory: %v", err.Error())
+	}
 	return &csi.CreateVolumeResponse{Volume: cs.nfsVolToCSI(nfsVol)}, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,10 @@ func (cs ControllerServer) CreateVolume(ctx context.Context, req csi.CreateVol`
`104`	`104`	`if err = os.Mkdir(internalVolumePath, 0777); err != nil && !os.IsExist(err) {`
`105`	`105`	`return nil, status.Errorf(codes.Internal, "failed to make subdirectory: %v", err.Error())`
`106`	`106`	`}`
	`107`	`+ // Reset directory permissions because of umask problems`
	`108`	`+ if err = os.Chmod(internalVolumePath, 0777); err != nil {`
	`109`	`+ klog.Warningf("failed to chmod subdirectory: %v", err.Error())`
	`110`	`+ }`
`107`	`111`	`return &csi.CreateVolumeResponse{Volume: cs.nfsVolToCSI(nfsVol)}, nil`
`108`	`112`	`}`
`109`	`113`