Skip to content

Commit 0c69186

Browse files
committed
Fix to make external-provisioner work
1 parent d055d86 commit 0c69186

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

params/const.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const (
2323
// fields in subsequent CSI calls or Kubernetes API objects.
2424
csiParameterPrefix = "csi.storage.k8s.io/"
2525

26-
prefixedFsTypeKey = csiParameterPrefix + "fstype"
26+
PrefixedFsTypeKey = csiParameterPrefix + "fstype"
2727

2828
prefixedDefaultSecretNameKey = csiParameterPrefix + "secret-name"
2929
prefixedDefaultSecretNamespaceKey = csiParameterPrefix + "secret-namespace"

params/volume.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
)
2626

2727
var (
28-
defaultSecretParams = SecretParamsMap{
28+
DefaultSecretParams = SecretParamsMap{
2929
name: "Default",
3030
secretNameKey: prefixedDefaultSecretNameKey,
3131
secretNamespaceKey: prefixedDefaultSecretNamespaceKey,
@@ -96,7 +96,7 @@ func GetVolumeSecretReference(secretParams SecretParamsMap, templateParams map[s
9696

9797
// if didn't find secrets for specific call, try to check default values
9898
if nameTemplate == "" && namespaceTemplate == "" {
99-
nameTemplate, namespaceTemplate, err = VerifyAndGetSecretNameAndNamespaceTemplate(defaultSecretParams, templateParams)
99+
nameTemplate, namespaceTemplate, err = VerifyAndGetSecretNameAndNamespaceTemplate(DefaultSecretParams, templateParams)
100100
if err != nil {
101101
return nil, fmt.Errorf("failed to get default name and namespace template from params: %v", err)
102102
}
@@ -155,13 +155,13 @@ func GetVolumeSecretReference(secretParams SecretParamsMap, templateParams map[s
155155
return ref, nil
156156
}
157157

158-
func RemovePrefixedParameters(param map[string]string) (map[string]string, error) {
158+
func RemovePrefixedVolumeParameters(param map[string]string) (map[string]string, error) {
159159
newParam := map[string]string{}
160160
for k, v := range param {
161161
if strings.HasPrefix(k, csiParameterPrefix) {
162162
// Check if its well known
163163
switch k {
164-
case prefixedFsTypeKey:
164+
case PrefixedFsTypeKey:
165165
case prefixedProvisionerSecretNameKey:
166166
case prefixedProvisionerSecretNamespaceKey:
167167
case prefixedControllerPublishSecretNameKey:

params/volume_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ func TestStripPrefixedCSIParams(t *testing.T) {
4343
},
4444
{
4545
name: "prefix in value",
46-
params: map[string]string{"foo": prefixedFsTypeKey, "bim": "baz"},
47-
expectedParams: map[string]string{"foo": prefixedFsTypeKey, "bim": "baz"},
46+
params: map[string]string{"foo": PrefixedFsTypeKey, "bim": "baz"},
47+
expectedParams: map[string]string{"foo": PrefixedFsTypeKey, "bim": "baz"},
4848
},
4949
{
5050
name: "all known prefixed",
5151
params: map[string]string{
52-
prefixedFsTypeKey: "csiBar",
52+
PrefixedFsTypeKey: "csiBar",
5353
prefixedProvisionerSecretNameKey: "csiBar",
5454
prefixedProvisionerSecretNamespaceKey: "csiBar",
5555
prefixedControllerPublishSecretNameKey: "csiBar",
@@ -106,7 +106,7 @@ func TestStripPrefixedCSIParams(t *testing.T) {
106106
for _, tc := range testcases {
107107
t.Logf("test: %v", tc.name)
108108

109-
newParams, err := RemovePrefixedParameters(tc.params)
109+
newParams, err := RemovePrefixedVolumeParameters(tc.params)
110110
if err != nil {
111111
if tc.expectErr {
112112
continue

0 commit comments

Comments
 (0)