Skip to content

Commit 68d085d

Browse files
committed
prow.sh: avoid AllAlpha=true
It turned out to not work. Instead of reverting the commit which introduced this, let's better document this explicitly.
1 parent b53d17b commit 68d085d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

prow.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,10 @@ configvar CSI_PROW_E2E_ALPHA "$(get_versioned_variable CSI_PROW_E2E_ALPHA "${csi
257257
configvar CSI_PROW_E2E_ALPHA_GATES_1_13 'VolumeSnapshotDataSource=true,BlockVolume=true,CSIBlockVolume=true' "alpha feature gates for Kubernetes 1.13"
258258
configvar CSI_PROW_E2E_ALPHA_GATES_1_14 'VolumeSnapshotDataSource=true' "alpha feature gates for Kubernetes 1.14"
259259
# TODO: add new CSI_PROW_ALPHA_GATES entry for future Kubernetes releases
260-
configvar CSI_PROW_E2E_ALPHA_GATES_LATEST 'AllAlpha=true' "alpha feature gates for latest Kubernetes"
260+
# Careful with AllAlpha=true: enabling all alpha features turned out
261+
# to be problematic (kubelet died), so let's better list alpha gates
262+
# explicitly.
263+
configvar CSI_PROW_E2E_ALPHA_GATES_LATEST 'VolumeSnapshotDataSource=true' "alpha feature gates for latest Kubernetes"
261264
configvar CSI_PROW_E2E_ALPHA_GATES "$(get_versioned_variable CSI_PROW_E2E_ALPHA_GATES "${csi_prow_kubernetes_version_suffix}")" "alpha E2E feature gates"
262265

263266
# Some tests are known to be unusable in a KinD cluster. For example,

0 commit comments

Comments
 (0)