Skip to content

Commit 05d5128

Browse files
authored
Merge pull request #299 from pohly/prow-update-master
master: update release-tools
2 parents 7053222 + a62db48 commit 05d5128

File tree

2 files changed

+19
-5
lines changed

2 files changed

+19
-5
lines changed

release-tools/SIDECAR_RELEASE_PROCESS.md

+11-5
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,11 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
3939
1. Changes can then be updated in all the sidecar repos and hostpath driver repo
4040
by following the [update
4141
instructions](https://github.com/kubernetes-csi/csi-release-tools/blob/master/README.md#sharing-and-updating).
42-
1. New pull and CI jobs are configured by
42+
1. New pull and CI jobs are configured by adding new K8s versions to the top of
4343
[gen-jobs.sh](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh).
44-
New pull jobs that have been unverified should be initially made optional.
45-
[Example](https://github.com/kubernetes/test-infra/pull/15055)
44+
New pull jobs that have been unverified should be initially made optional by
45+
setting the new K8s version as
46+
[experimental](https://github.com/kubernetes/test-infra/blob/a1858f46d6014480b130789df58b230a49203a64/config/jobs/kubernetes-csi/gen-jobs.sh#L40).
4647
1. Once new pull and CI jobs have been verified, and the new Kubernetes version
4748
is released, we can make the optional jobs required, and also remove the
4849
Kubernetes versions that are no longer supported.
@@ -54,14 +55,19 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
5455
generator](https://github.com/kubernetes/release/tree/master/cmd/release-notes)
5556
1. Generate release notes for the release. Replace arguments with the relevant
5657
information.
58+
* Clean up old cached information (also needed if you are generating release
59+
notes for multiple repos)
60+
```bash
61+
rm -rf /tmp/k8s-repo
62+
```
5763
* For new minor releases on master:
58-
```
64+
```bash
5965
GITHUB_TOKEN=<token> release-notes --discover=mergebase-to-latest
6066
--github-org=kubernetes-csi --github-repo=external-provisioner
6167
--required-author="" --output out.md
6268
```
6369
* For new patch releases on a release branch:
64-
```
70+
```bash
6571
GITHUB_TOKEN=<token> release-notes --discover=patch-to-latest --branch=release-1.1
6672
--github-org=kubernetes-csi --github-repo=external-provisioner
6773
--required-author="" --output out.md

release-tools/prow.sh

+8
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,10 @@ configvar CSI_PROW_DRIVER_INSTALL "install_csi_driver" "name of the shell functi
211211
# still use that name.
212212
configvar CSI_PROW_DRIVER_CANARY "${CSI_PROW_HOSTPATH_CANARY}" "driver image override for canary images"
213213

214+
# Image registry to use for canary images.
215+
# Only valid if CSI_PROW_DRIVER_CANARY == "canary".
216+
configvar CSI_PROW_DRIVER_CANARY_REGISTRY "gcr.io/k8s-staging-sig-storage" "registry for canary images"
217+
214218
# The E2E testing can come from an arbitrary repo. The expectation is that
215219
# the repo supports "go test ./test/e2e -args --storage.testdriver" (https://github.com/kubernetes/kubernetes/pull/72836)
216220
# after setting KUBECONFIG. As a special case, if the repository is Kubernetes,
@@ -693,7 +697,11 @@ install_csi_driver () {
693697
fi
694698

695699
if [ "${CSI_PROW_DRIVER_CANARY}" != "stable" ]; then
700+
if [ "${CSI_PROW_DRIVER_CANARY}" == "canary" ]; then
701+
images="$images IMAGE_TAG=${CSI_PROW_DRIVER_CANARY} IMAGE_REGISTRY=${CSI_PROW_DRIVER_CANARY_REGISTRY}"
702+
else
696703
images="$images IMAGE_TAG=${CSI_PROW_DRIVER_CANARY}"
704+
fi
697705
fi
698706
# Ignore: Double quote to prevent globbing and word splitting.
699707
# It's intentional here for $images.

0 commit comments

Comments
 (0)