Add idempotency loop for controller operations

Similar to Node operations, add loop for controller operations as well.

Author: okartau

pkg/sanity/controller.go

@@ -123,6 +123,13 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
 	AfterEach(func() {
 		cl.DeleteVolumes()
 	})
+	idempotentcount := sc.Config.IdempotentCount
+	// Negative value for Idempotency repeat count means "skip idempotency testing"
+	// We also do not want zero as that would skip as well, so in special cases we
+	// reset the loop count to 1 to make this happen as regular testing.
+	if idempotentcount < 1 {
+		idempotentcount = 1
+	}
 
 	Describe("ControllerGetCapabilities", func() {
 		It("should return appropriate capabilities", func() {
@@ -1110,19 +1117,21 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
 			// ControllerPublishVolume
 			By("calling controllerpublish on that volume")
 
-			conpubvol, err := c.ControllerPublishVolume(
-				context.Background(),
-				&csi.ControllerPublishVolumeRequest{
-					VolumeId:         vol.GetVolume().GetVolumeId(),
-					NodeId:           ni.GetNodeId(),
-					VolumeCapability: TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
-					Readonly:         false,
-					Secrets:          sc.Secrets.ControllerPublishVolumeSecret,
-				},
-			)
-			Expect(err).NotTo(HaveOccurred())
+			for i := 0; i < idempotentcount; i++ {
+				conpubvol, err := c.ControllerPublishVolume(
+					context.Background(),
+					&csi.ControllerPublishVolumeRequest{
+						VolumeId:         vol.GetVolume().GetVolumeId(),
+						NodeId:           ni.GetNodeId(),
+						VolumeCapability: TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
+						Readonly:         false,
+						Secrets:          sc.Secrets.ControllerPublishVolumeSecret,
+					},
+				)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(conpubvol).NotTo(BeNil())
+			}
 			cl.RegisterVolume(name, VolumeInfo{VolumeID: vol.GetVolume().GetVolumeId(), NodeID: ni.GetNodeId()})
-			Expect(conpubvol).NotTo(BeNil())
 
 			By("cleaning up unpublishing the volume")