Skip to content

Commit a0d10a5

Browse files
committed
issue-174, test case fixed, SP may not set default value for block volume create request
1 parent 1534043 commit a0d10a5

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

pkg/sanity/controller.go

+13
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,9 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
428428
VolumeCapabilities: []*csi.VolumeCapability{
429429
TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
430430
},
431+
CapacityRange: &csi.CapacityRange{
432+
RequiredBytes: TestVolumeSize(sc),
433+
},
431434
Secrets: sc.Secrets.CreateVolumeSecret,
432435
Parameters: sc.Config.TestVolumeParameters,
433436
},
@@ -833,6 +836,9 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
833836
VolumeCapabilities: []*csi.VolumeCapability{
834837
TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
835838
},
839+
CapacityRange: &csi.CapacityRange{
840+
RequiredBytes: TestVolumeSize(sc),
841+
},
836842
Secrets: sc.Secrets.CreateVolumeSecret,
837843
Parameters: sc.Config.TestVolumeParameters,
838844
},
@@ -886,6 +892,9 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
886892
VolumeCapabilities: []*csi.VolumeCapability{
887893
TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
888894
},
895+
CapacityRange: &csi.CapacityRange{
896+
RequiredBytes: TestVolumeSize(sc),
897+
},
889898
Secrets: sc.Secrets.CreateVolumeSecret,
890899
Parameters: sc.Config.TestVolumeParameters,
891900
},
@@ -900,6 +909,7 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
900909
context.Background(),
901910
&csi.ValidateVolumeCapabilitiesRequest{
902911
VolumeId: vol.GetVolume().GetVolumeId(),
912+
VolumeCapabilities: nil,
903913
Secrets: sc.Secrets.ControllerValidateVolumeCapabilitiesSecret,
904914
})
905915
Expect(err).To(HaveOccurred())
@@ -934,6 +944,9 @@ var _ = DescribeSanity("Controller Service [Controller Server]", func(sc *TestCo
934944
VolumeCapabilities: []*csi.VolumeCapability{
935945
TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
936946
},
947+
CapacityRange: &csi.CapacityRange{
948+
RequiredBytes: TestVolumeSize(sc),
949+
},
937950
Secrets: sc.Secrets.CreateVolumeSecret,
938951
Parameters: sc.Config.TestVolumeParameters,
939952
},

pkg/sanity/node.go

+3
Original file line numberDiff line numberDiff line change
@@ -631,6 +631,9 @@ var _ = DescribeSanity("Node Service", func(sc *TestContext) {
631631
VolumeCapabilities: []*csi.VolumeCapability{
632632
TestVolumeCapabilityWithAccessType(sc, csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER),
633633
},
634+
CapacityRange: &csi.CapacityRange{
635+
RequiredBytes: TestVolumeSize(sc),
636+
},
634637
Secrets: sc.Secrets.CreateVolumeSecret,
635638
Parameters: sc.Config.TestVolumeParameters,
636639
AccessibilityRequirements: accReqs,

0 commit comments

Comments
 (0)