Skip to content

Commit 8a62ab7

Browse files
authored
Merge pull request #262 from pohly/vendor-k8s-1.14
vendor: update to k8s.io 1.14, avoid glog
2 parents 918496d + 0334a68 commit 8a62ab7

23 files changed

+472
-1584
lines changed

Gopkg.lock

Lines changed: 12 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,19 @@
4444
name = "github.com/kubernetes-csi/external-snapshotter"
4545
branch = "master"
4646

47+
# We need a version which does not use glog, because pulling in glog clashes
48+
# with klog.Init. Anything >= 1.12 is fine, but we can't specify that
49+
# because of the lack of semantic versioning in Kubernetes. Therefore we
50+
# have to pick a certain release, otherwise we (more or less randomly) end
51+
# up with something older or master.
52+
[[constraint]]
53+
name = "k8s.io/apiserver"
54+
version = "kubernetes-1.14.0"
55+
56+
[[constraint]]
57+
name = "k8s.io/component-base"
58+
version = "kubernetes-1.14.0"
59+
4760
[prune]
4861
non-go = true
4962
go-tests = true

cmd/csi-provisioner/csi-provisioner.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import (
4040
"k8s.io/klog"
4141

4242
utilfeature "k8s.io/apiserver/pkg/util/feature"
43-
utilflag "k8s.io/apiserver/pkg/util/flag"
43+
utilflag "k8s.io/component-base/cli/flag"
4444
csitranslationlib "k8s.io/csi-translation-lib"
4545
)
4646

@@ -76,7 +76,7 @@ func init() {
7676
flag.Set("logtostderr", "true")
7777
flag.Parse()
7878

79-
if err := utilfeature.DefaultFeatureGate.SetFromMap(featureGates); err != nil {
79+
if err := utilfeature.DefaultMutableFeatureGate.SetFromMap(featureGates); err != nil {
8080
klog.Fatal(err)
8181
}
8282

pkg/features/features.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const (
2626
)
2727

2828
func init() {
29-
utilfeature.DefaultFeatureGate.Add(defaultKubernetesFeatureGates)
29+
utilfeature.DefaultMutableFeatureGate.Add(defaultKubernetesFeatureGates)
3030
}
3131

3232
// defaultKubernetesFeatureGates consists of all known feature keys specific to external-provisioner.

vendor/github.com/golang/glog/LICENSE

Lines changed: 0 additions & 191 deletions
This file was deleted.

0 commit comments

Comments
 (0)