Skip to content

Commit fd73d0d

Browse files
authored
Merge pull request #260 from cwdsuzhou/master
Bugfix: get csinode err overrided by parse err
2 parents a0ceb86 + 9f17114 commit fd73d0d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/controller/topology.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,9 @@ func getSelectedCSINode(
236236
//
237237
// TODO (#257): Once K8s 1.13 is no longer supported, then this check can be removed
238238
// and we can require that CSINode exists.
239-
nodeVersion, err := version.ParseSemantic(selectedNode.Status.NodeInfo.KubeletVersion)
240-
if err != nil {
241-
return nil, fmt.Errorf("Failed to parse kubelet version from node %q: %v", selectedNode.Name, err)
239+
nodeVersion, parseErr := version.ParseSemantic(selectedNode.Status.NodeInfo.KubeletVersion)
240+
if parseErr != nil {
241+
return nil, fmt.Errorf("Failed to parse kubelet version from node %q: %v", selectedNode.Name, parseErr)
242242
}
243243
if nodeVersion.LessThan(k8sTopologyBetaVersion) {
244244
klog.Warningf("Selected node %q version %q is less than %q, falling back to no topology", selectedNode.Name, nodeVersion, k8sTopologyBetaVersion)

0 commit comments

Comments
 (0)