You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: release-tools/SIDECAR_RELEASE_PROCESS.md
+11-16
Original file line number
Diff line number
Diff line change
@@ -9,13 +9,8 @@ The release manager must:
9
9
* Be a member of the kubernetes-csi organization. Open an
10
10
[issue](https://github.com/kubernetes/org/issues/new?assignees=&labels=area%2Fgithub-membership&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E) in
11
11
kubernetes/org to request membership
12
-
* Be a top level approver for the repository. To become a top level approver,
13
-
the candidate must demonstrate ownership and deep knowledge of the repository
14
-
through active maintenance, responding to and fixing issues, reviewing PRs,
15
-
test triage.
16
-
* Be part of the maintainers or admin group for the repository. admin is a
17
-
superset of maintainers, only maintainers level is required for cutting a
18
-
release. Membership can be requested by submitting a PR to kubernetes/org.
12
+
* Be part of the maintainers group for the repository.
13
+
Membership can be requested by submitting a PR to kubernetes/org.
# This builds each command (= the sub-directories of ./cmd) for the target platform(s)
78
85
# defined by BUILD_PLATFORMS.
79
86
$(CMDS:%=build-%): build-%: check-go-version-go
80
87
mkdir -p bin
81
-
echo '$(BUILD_PLATFORMS)' | tr ';' '\n' | while read -r os arch suffix; do \
82
-
if ! (set -x; CGO_ENABLED=0 GOOS="$$os" GOARCH="$$arch" go build $(GOFLAGS_VENDOR) -a -ldflags '$(FULL_LDFLAGS)' -o "./bin/$*$$suffix" ./cmd/$*); then \
88
+
# os_arch_seen captures all of the $$os-$$arch seen for the current binary
89
+
# that we want to build, if we've seen an $$os-$$arch before it means that
90
+
# we don't need to build it again, this is done to avoid building
91
+
# the windows binary multiple times (see the default value of $$BUILD_PLATFORMS)
92
+
export os_arch_seen="" && echo '$(BUILD_PLATFORMS)' | tr ';' '\n' | while read -r os arch suffix base_image addon_image; do \
if ! [ $${#os_arch_seen_pre} = $${#os_arch_seen} ]; then \
95
+
continue; \
96
+
fi; \
97
+
if ! (set -x; cd ./$(CMDS_DIR)/$* && CGO_ENABLED=0 GOOS="$$os" GOARCH="$$arch" go build $(GOFLAGS_VENDOR) -a -ldflags '$(FULL_LDFLAGS)' -o "$(abspath ./bin)/$*$$suffix" .); then \
83
98
echo "Building $* for GOOS=$$os GOARCH=$$arch failed, see error(s) above."; \
0 commit comments