Skip to content

Fix external-snapshotter sidecar container RBAC rule #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xing-yang opened this issue Nov 9, 2018 · 3 comments · Fixed by #56
Closed

Fix external-snapshotter sidecar container RBAC rule #55

xing-yang opened this issue Nov 9, 2018 · 3 comments · Fixed by #56

Comments

@xing-yang
Copy link
Collaborator

We don't need "create", "delete", "update" for PV and PVC resources in the external-snapshotter RBAC rule. We only need "get", "list", "watch". We should clean up the following rbac.yaml file.

https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/rbac.yaml

@wackxu
Copy link
Contributor

wackxu commented Nov 12, 2018

Will fix this

@wackxu wackxu mentioned this issue Nov 13, 2018
@pohly
Copy link
Contributor

pohly commented Nov 14, 2018

Once this is fixed, please ensure that it propagates also to those places which use the modified file:

@pohly
Copy link
Contributor

pohly commented Nov 14, 2018

If you want, file a bug against kubernetes-csi/docs and assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants