Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 4f8ab5f

Browse files
authored
Merge pull request #124 from vincepri/remove-fix
Remove gvk hack from deferred patch
2 parents d056546 + b86140c commit 4f8ab5f

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

controllers/kubeadmconfig_controller.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,15 +287,9 @@ func (r *KubeadmConfigReconciler) SetupWithManager(mgr ctrl.Manager) error {
287287
}
288288

289289
func (r *KubeadmConfigReconciler) patchConfig(ctx context.Context, config *cabpkv1alpha2.KubeadmConfig, patchConfig client.Patch) error {
290-
// TODO(ncdc): remove this once we've updated to a version of controller-runtime with
291-
// https://github.com/kubernetes-sigs/controller-runtime/issues/526.
292-
gvk := config.GroupVersionKind()
293290
if err := r.Patch(ctx, config, patchConfig); err != nil {
294291
return err
295292
}
296-
// TODO(ncdc): remove this once we've updated to a version of controller-runtime with
297-
// https://github.com/kubernetes-sigs/controller-runtime/issues/526.
298-
config.SetGroupVersionKind(gvk)
299293
if err := r.Status().Patch(ctx, config, patchConfig); err != nil {
300294
return err
301295
}

0 commit comments

Comments
 (0)