Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Commit 5bef887

Browse files
committed
Streamline make generate
Signed-off-by: Vince Prignano <[email protected]>
1 parent 45b6740 commit 5bef887

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

Makefile

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ all: manager
4949

5050
# Run tests
5151
.PHONY: test
52-
test: generate fmt vet manifests
52+
test: generate fmt vet
5353
go test ./api/... ./controllers/... -coverprofile cover.out
5454

5555
# Build manager binary
@@ -64,20 +64,15 @@ run: generate fmt vet
6464

6565
# Install CRDs into a cluster
6666
.PHONY: install
67-
install: manifests
67+
install: generate
6868
kubectl apply -f config/crd/bases
6969

7070
# Deploy controller in the configured Kubernetes cluster in ~/.kube/config
7171
.PHONY: deploy
72-
deploy: manifests
72+
deploy: generate
7373
kubectl apply -f config/crd/bases
7474
kubectl kustomize config/default | kubectl apply -f -
7575

76-
# Generate manifests e.g. CRD, RBAC etc.
77-
.PHONY: manifests
78-
manifests: $(CONTROLLER_GEN)
79-
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:dir=$(CRD_ROOT) output:webhook:dir=$(WEBHOOK_ROOT) output:rbac:dir=$(RBAC_ROOT)
80-
8176
# Run go fmt against code
8277
.PHONY: fmt
8378
fmt:
@@ -91,8 +86,19 @@ vet:
9186
# Generate code
9287
.PHONY: generate
9388
generate: $(CONTROLLER_GEN)
89+
$(MAKE) generate-manifests
90+
$(MAKE) generate-deepcopy
91+
92+
# Generate deepcopy files.
93+
.PHONY: generate-deepcopy
94+
generate-deepcopy: $(CONTROLLER_GEN)
9495
$(CONTROLLER_GEN) object:headerFile=./hack/boilerplate/boilerplate.generatego.txt paths=./api/...
9596

97+
# Generate manifests e.g. CRD, RBAC etc.
98+
.PHONY: generate-manifests
99+
generate-manifests: $(CONTROLLER_GEN)
100+
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:dir=$(CRD_ROOT) output:webhook:dir=$(WEBHOOK_ROOT) output:rbac:dir=$(RBAC_ROOT)
101+
96102
# Build the docker image
97103
.PHONY: docker-build
98104
docker-build: test

hack/verify-manifests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ cleanup() {
2828
trap "cleanup" EXIT SIGINT
2929
cleanup
3030

31-
MANIFEST_ROOT=$TMP_ROOT make manifests
31+
MANIFEST_ROOT=$TMP_ROOT make generate-manifests
3232

3333
echo "diffing ${DIFFROOT} against freshly generated manifests"
3434
ret=0
@@ -37,6 +37,6 @@ if [[ $ret -eq 0 ]]
3737
then
3838
echo "Manifests in ${DIFFROOT} are up to date."
3939
else
40-
echo "Manifests in ${DIFFROOT} are out of date. Please run \`make manifests\`"
40+
echo "Manifests in ${DIFFROOT} are out of date. Please run \`make generate-manifests\`"
4141
exit 1
4242
fi

0 commit comments

Comments
 (0)