Skip to content

Commit 1b17213

Browse files
committed
added testcase to TestGetContainerReference
1 parent b753585 commit 1b17213

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

pkg/blob/blob_test.go

+18-12
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ import (
3636
"k8s.io/client-go/kubernetes"
3737
"k8s.io/client-go/kubernetes/fake"
3838

39+
//fakecloud "k8s.io/cloud-provider/fake"
40+
3941
"sigs.k8s.io/blob-csi-driver/pkg/util"
4042
"sigs.k8s.io/cloud-provider-azure/pkg/azureclients/storageaccountclient/mockstorageaccountclient"
4143
azure "sigs.k8s.io/cloud-provider-azure/pkg/provider"
@@ -749,10 +751,11 @@ func TestGetContainerReference(t *testing.T) {
749751
fakeAccountKey := "test-key"
750752
fakeContainerName := "test-con"
751753
testCases := []struct {
752-
name string
753-
containerName string
754-
secrets map[string]string
755-
expectedError error
754+
name string
755+
containerName string
756+
endpointSuffix string
757+
secrets map[string]string
758+
expectedError error
756759
}{
757760
{
758761
name: "failed to retrieve accountName",
@@ -783,23 +786,26 @@ func TestGetContainerReference(t *testing.T) {
783786
},
784787
expectedError: fmt.Errorf("azure: base storage service url required"),
785788
},
786-
/*{
787-
name: "container reference is nil",
788-
containerName: fakeContainerName,
789+
{
790+
name: "Successful I/O",
791+
containerName: fakeContainerName,
792+
endpointSuffix: "endpointSuffix",
789793
secrets: map[string]string{
790-
"accountName": fakeAccountName,
794+
"accountName": "devstoreaccount1",
791795
"accountKey": fakeAccountKey,
792796
},
793-
expectedError: fmt.Errorf("ContainerReference of %s is nil", fakeContainerName),
794-
},*/
797+
expectedError: nil,
798+
},
795799
}
796800

797801
d := NewFakeDriver()
798-
d.cloud = &azure.Cloud{}
802+
d.cloud = azure.GetTestCloud(gomock.NewController(t))
803+
//encodedStr := base64.StdEncoding.EncodeToString([]byte{12, 34, 56})
799804
d.cloud.KubeClient = fake.NewSimpleClientset()
800-
//d.cloud.Environment.StorageEndpointSuffix =
805+
801806
for _, tc := range testCases {
802807
t.Run(tc.name, func(t *testing.T) {
808+
d.cloud.Environment.StorageEndpointSuffix = tc.endpointSuffix
803809
container, err := getContainerReference(tc.containerName, tc.secrets, d.cloud.Environment)
804810
if tc.expectedError != nil {
805811
assert.Error(t, err)

0 commit comments

Comments
 (0)