Skip to content

Commit 8486bcb

Browse files
committed
test: add unit test
fix
1 parent 5784a6e commit 8486bcb

File tree

2 files changed

+56
-8
lines changed

2 files changed

+56
-8
lines changed

pkg/util/util.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,7 @@ func GetMountOptions(options []string) string {
9999
}
100100

101101
func MakeDir(pathname string, perm os.FileMode) error {
102-
err := os.MkdirAll(pathname, perm)
103-
if err != nil {
102+
if err := os.MkdirAll(pathname, perm); err != nil {
104103
if !os.IsExist(err) {
105104
return err
106105
}

pkg/util/util_test.go

+55-6
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,14 @@ package util
1919
import (
2020
"fmt"
2121
"os"
22+
"path/filepath"
2223
"reflect"
2324
"testing"
2425
"time"
2526

2627
"github.com/stretchr/testify/assert"
2728
"go.uber.org/mock/gomock"
29+
"k8s.io/kubernetes/pkg/volume"
2830
)
2931

3032
func TestRoundUpBytes(t *testing.T) {
@@ -164,14 +166,18 @@ func TestGetMountOptions(t *testing.T) {
164166
}
165167

166168
func TestMakeDir(t *testing.T) {
167-
//Successfully create directory
168-
targetTest := "./target_test"
169+
// Successfully create directory
170+
targetTest := filepath.Join(os.TempDir(), "TestMakeDir")
169171
err := MakeDir(targetTest, 0777)
170-
assert.NoError(t, err)
172+
defer func() {
173+
err := os.RemoveAll(targetTest)
174+
assert.NoError(t, err)
175+
}()
171176

172-
// Remove the directory created
173-
err = os.RemoveAll(targetTest)
174-
assert.NoError(t, err)
177+
// create an existing directory
178+
if err = MakeDir(targetTest, 0755); err != nil {
179+
t.Errorf("Unexpected error: %v", err)
180+
}
175181
}
176182

177183
func TestConvertTagsToMap(t *testing.T) {
@@ -614,6 +620,11 @@ users:
614620
envVariableHasConfig: false,
615621
envVariableConfigIsValid: false,
616622
},
623+
{
624+
desc: "no-need-kubeconfig",
625+
kubeconfig: "no-need-kubeconfig",
626+
expectError: false,
627+
},
617628
}
618629

619630
for _, test := range tests {
@@ -625,6 +636,44 @@ users:
625636
}
626637
}
627638

639+
func TestVolumeMounter(t *testing.T) {
640+
path := "/mnt/data"
641+
attributes := volume.Attributes{}
642+
643+
mounter := &VolumeMounter{
644+
path: path,
645+
attributes: attributes,
646+
}
647+
648+
if mounter.GetPath() != path {
649+
t.Errorf("Expected path %s, but got %s", path, mounter.GetPath())
650+
}
651+
652+
if mounter.GetAttributes() != attributes {
653+
t.Errorf("Expected attributes %v, but got %v", attributes, mounter.GetAttributes())
654+
}
655+
656+
if err := mounter.CanMount(); err != nil {
657+
t.Errorf("Unexpected error: %v", err)
658+
}
659+
660+
if err := mounter.SetUp(volume.MounterArgs{}); err != nil {
661+
t.Errorf("Unexpected error: %v", err)
662+
}
663+
664+
if err := mounter.SetUpAt("", volume.MounterArgs{}); err != nil {
665+
t.Errorf("Unexpected error: %v", err)
666+
}
667+
668+
metrics, err := mounter.GetMetrics()
669+
if err != nil {
670+
t.Errorf("Unexpected error: %v", err)
671+
}
672+
if metrics != nil {
673+
t.Errorf("Expected nil metrics, but got %v", metrics)
674+
}
675+
}
676+
628677
func TestSetVolumeOwnership(t *testing.T) {
629678
tmpVDir, err := os.MkdirTemp(os.TempDir(), "SetVolumeOwnership")
630679
if err != nil {

0 commit comments

Comments
 (0)