Skip to content

Version missmatch between GitHub release and helm chart version #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sphinx02 opened this issue Jul 1, 2022 · 13 comments · Fixed by #715
Closed

Version missmatch between GitHub release and helm chart version #714

sphinx02 opened this issue Jul 1, 2022 · 13 comments · Fixed by #715

Comments

@sphinx02
Copy link

sphinx02 commented Jul 1, 2022

Hi,
following the last 2 releases of the blob-csi-driver I recognized that the chart- and app-version of the helm-chart is always one version higher than the release version of the blob-csi-driver in GitHub.

Currently e.g. if listing the helm-chart versions:
grafik

And if looking at the GitHub releases page:
grafik

As far as I understand is e.g. the current helm-chart with chart-version v1.16 matching the GitHub-Release v1.15. That is quite confusing, especially if changelog is of interest.

Is there any chance to keep at least the app-version in sync with the version of the GitHub release version? Even better would be to keep both in sync.

@andyzhangx
Copy link
Member

hi, v1.16 is master branch and not released, so it's using latest tag. and master branch is only for testing purpose.

@sphinx02
Copy link
Author

sphinx02 commented Jul 4, 2022

@andyzhangx but how do I know which helm-chart version contains which GitHub release generally?

@andyzhangx
Copy link
Member

@sphinx02 I think you could use v1.15.0 helm-chart version, it would have v1.15.0 GitHub release

@sphinx02
Copy link
Author

sphinx02 commented Jul 4, 2022

@andyzhangx thats exactly my problem, I think v1.15.0 helm-chart contains v1.14.0 GitHub release, as the v1.15.0 helm-chart did already exist 10 days ago when I created #706 .

It is the same now: The v1.16.0 helm-chart contains the v1.15.0 GitHub release, that is what is confusing me.

@andyzhangx
Copy link
Member

Current v1.16.0 helm-chart actually contains the latest GitHub release which is for testing purpose, and when v1.16.0 is released, it would contain v1.16.0 GitHub release, and now you could try v1.15.0 which is the latest released version.

we could not set version as latest(invalid format) in charts/latest/blob-csi-driver/Chart.yaml, that's reason we always set as a higher version than latest released version, so user could still install master branch chart for testing purpose:

  • right way to install latest released version:
helm repo add blob-csi-driver https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver/master/charts
helm repo update
helm install blob-csi-driver blob-csi-driver/blob-csi-driver --set node.enableBlobfuseProxy=true --namespace kube-system --version v1.15.0

@sphinx02
Copy link
Author

sphinx02 commented Jul 4, 2022

Sorry, I still dont get it. Does that mean that in this case the helm-chart version v1.15.0 did change over time?

@andyzhangx
Copy link
Member

Sorry, I still dont get it. Does that mean that in this case the helm-chart version v1.15.0 did change over time?

@sphinx02 NO, v1.15.0 is released, so it won't change over time, and v1.16.0 is master branch version, it may change in the future.

@sphinx02
Copy link
Author

sphinx02 commented Jul 4, 2022

I am not sure but I think we had the same thing with v1.15.0, it was latest helm-chart until you recently made the v1.15.0 GitHub release. If you ask me that is completely confusing. I have various clusters running on v1.15.0 helm-chart which was available since more than 2 weeks but since the v1.15.0 GitHub release, the v1.15.0 helm-chart version seem to be something different now.

I recommend to use a different repo for unversioned and untestet latest master-charts like:
helm repo add blob-csi-driver-master https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver-master/master/charts
or
helm repo add blob-csi-driver-beta https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver-beta/master/charts

I think it is quite confusing and in production environments even dangerous if identical helm-chart version differs over time.

@andyzhangx
Copy link
Member

@sphinx02 what about add such notes: #715

@sphinx02
Copy link
Author

sphinx02 commented Jul 4, 2022

To be honest, I dont think that is enough. I am not sure if its only me but if there is an offical helm-repository of a GA helm tool I expect that the latest helm-chart is the latest stable one. Untested master releases should never be the latest release of a GA helm repository.

@andyzhangx
Copy link
Member

use helm repo add blob-csi-driver https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver/v1.15.0/charts should fix the issue:

helm repo remove blob-csi-driver
helm repo add blob-csi-driver https://raw.githubusercontent.com/kubernetes-sigs/blob-csi-driver/v1.15.0/charts
helm search repo -l blob-csi-driver
NAME                                    CHART VERSION   APP VERSION     DESCRIPTION
blob-csi-driver/blob-csi-driver         v1.15.0         v1.15.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.14.0         v1.14.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.13.0         v1.13.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.12.0         v1.12.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.11.0         v1.11.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.10.0         v1.10.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.9.0          v1.9.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.8.0          v1.8.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.7.0          v1.7.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.6.0          v1.6.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.5.0          v1.5.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.4.1          v1.4.1          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.4.0          v1.4.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.3.0          v1.3.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.2.0          v1.2.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.1.0          v1.1.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v1.0.0          v1.0.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v0.11.0         v0.11.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v0.10.0         v0.10.0         Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v0.9.0          v0.9.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v0.8.0          v0.8.0          Azure Blob Storage CSI driver
blob-csi-driver/blob-csi-driver         v0.7.0          v0.7.0          Azure Blob Storage CSI driver
blob-csi-driver/blobfuse-csi-driver     v0.6.0          v0.6.0          BlobFuse Container Storage Interface (CSI) Stor

@andyzhangx
Copy link
Member

I think set master branch chart version as v0.0.0 should fix the issue ultimately, then there would be no confusion, and user could update master branch chart repo to get updated versions from time to time: #715

@sphinx02
Copy link
Author

sphinx02 commented Jul 5, 2022

@andyzhangx that sounds great. This way the latest release is always the latest stable release and also a versioned release does not change over time (except the special master v0.0.0 release). Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants