keep metrics as port name

Co-authored-by: Furkat Gofurov <[email protected]>

Author: Arakos

hack/charts/cluster-api-operator/templates/deployment.yaml

@@ -100,10 +100,10 @@ spec:
           {{- if $.Values.diagnosticsAddress }}
           {{- $diagnosticsPort := $.Values.diagnosticsAddress }}
           {{- if contains ":" $diagnosticsPort -}}
-          {{ $diagnosticsPort = ( split ":" $.Values.diagnosticsAddress)._1 }}
+          {{ $diagnosticsPort = ( split ":" $.Values.diagnosticsAddress)._1 | int }}
           {{- end }}
         - containerPort: {{ $diagnosticsPort | int }}
-          name: diagnostics
+          name: metrics
           protocol: TCP
           {{- end }}
         {{- with .Values.resources.manager }}

test/e2e/resources/full-chart-install.yaml

@@ -28399,7 +28399,7 @@ spec:
           name: webhook-server
           protocol: TCP
         - containerPort: 8443
-          name: diagnostics
+          name: metrics
           protocol: TCP
         resources:
             limits: