Merge pull request #5019 from nueavv/main

k8s-ci-robot · web-flow · commit 0390efe2cc41 · 2025-01-28T10:35:23.000-08:00
🐛 fix(nodegroup): add nil pointer check for nodegroup version
diff --git a/pkg/cloud/services/eks/nodegroup.go b/pkg/cloud/services/eks/nodegroup.go
@@ -333,6 +333,11 @@ func (s *NodegroupService) reconcileNodegroupVersion(ng *eks.Nodegroup) error {
 			return fmt.Errorf("parsing EKS version from spec: %w", err)
 		}
 	}
+
+	// Check for nil pointers before dereferencing
+	if ng.Version == nil {
+		return fmt.Errorf("nodegroup version is nil")
+	}
 	ngVersion := version.MustParseGeneric(*ng.Version)
 	specAMI := s.scope.ManagedMachinePool.Spec.AMIVersion
 	ngAMI := *ng.ReleaseVersion

Original file line number	Diff line number	Diff line change
`@@ -333,6 +333,11 @@ func (s NodegroupService) reconcileNodegroupVersion(ng eks.Nodegroup) error {`
`333`	`333`	`return fmt.Errorf("parsing EKS version from spec: %w", err)`
`334`	`334`	`}`
`335`	`335`	`}`
	`336`	`+`
	`337`	`+ // Check for nil pointers before dereferencing`
	`338`	`+ if ng.Version == nil {`
	`339`	`+ return fmt.Errorf("nodegroup version is nil")`
	`340`	`+ }`
`336`	`341`	`ngVersion := version.MustParseGeneric(*ng.Version)`
`337`	`342`	`specAMI := s.scope.ManagedMachinePool.Spec.AMIVersion`
`338`	`343`	`ngAMI := *ng.ReleaseVersion`