Skip to content

Commit 236a1a2

Browse files
committed
🌱 fix linting predeclared issue
This fixes the issue of shadowing the builtins `min`/`max` shadowed by local variables declaration. This has been fixed in newer branches via #5255
1 parent f4bd35e commit 236a1a2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

exp/api/v1beta2/awsmanagedmachinepool_webhook.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,18 @@ func (r *AWSManagedMachinePool) validateScaling() field.ErrorList {
5959
if r.Spec.Scaling != nil { //nolint:nestif
6060
minField := field.NewPath("spec", "scaling", "minSize")
6161
maxField := field.NewPath("spec", "scaling", "maxSize")
62-
min := r.Spec.Scaling.MinSize
63-
max := r.Spec.Scaling.MaxSize
64-
if min != nil {
65-
if *min < 0 {
66-
allErrs = append(allErrs, field.Invalid(minField, *min, "must be greater or equal zero"))
62+
minSize := r.Spec.Scaling.MinSize
63+
maxSize := r.Spec.Scaling.MaxSize
64+
if minSize != nil {
65+
if *minSize < 0 {
66+
allErrs = append(allErrs, field.Invalid(minField, *minSize, "must be greater or equal zero"))
6767
}
68-
if max != nil && *max < *min {
69-
allErrs = append(allErrs, field.Invalid(maxField, *max, fmt.Sprintf("must be greater than field %s", minField.String())))
68+
if maxSize != nil && *maxSize < *minSize {
69+
allErrs = append(allErrs, field.Invalid(maxField, *maxSize, fmt.Sprintf("must be greater than field %s", minField.String())))
7070
}
7171
}
72-
if max != nil && *max < 0 {
73-
allErrs = append(allErrs, field.Invalid(maxField, *max, "must be greater than zero"))
72+
if maxSize != nil && *maxSize < 0 {
73+
allErrs = append(allErrs, field.Invalid(maxField, *maxSize, "must be greater than zero"))
7474
}
7575
}
7676
if len(allErrs) == 0 {

0 commit comments

Comments
 (0)