-
Notifications
You must be signed in to change notification settings - Fork 602
Remove deprecated admission interfaces from API types #5450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/triage accepted |
I think we'll want to tackle this independently of the CAPI bump, so we can contain the scope of the changes. |
Some examples on how to do this can also be found on CAPG's PR: https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1459/files |
This issue is labeled with You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/triage accepted |
controller-runtime has removed the
admission.Defaulter
andadmission.Validator
interfaces as of v0.20.0 (kubernetes-sigs/controller-runtime#2877)cluster-api v1.10 uses a version of controller-runtime that no longer has these present.
Looking through related PR history, CAPI has provided an implementer's guide for transitioning these interfaces out of API packages. https://cluster-api.sigs.k8s.io/developer/providers/getting-started/implement-api-types#registering-apis-in-the-scheme
There's also some prior art in how CAPI itself removed these here: kubernetes-sigs/cluster-api#9045
The text was updated successfully, but these errors were encountered: