Skip to content

AzureEnvironment Support for Managed Clusters #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luthermonson opened this issue Apr 27, 2023 · 1 comment · Fixed by #3509
Closed

AzureEnvironment Support for Managed Clusters #3489

luthermonson opened this issue Apr 27, 2023 · 1 comment · Fixed by #3509
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/feature Categorizes issue or PR as related to a new feature. kind/proposal Issues or PRs related to proposals.

Comments

@luthermonson
Copy link
Contributor

Goals

  1. Add a new string to managed cluster spec identical to this in azureclusterspec
  2. Pass through the AzureEnvironment for the managed cluster to the scope creation for example both here and here. This is identical behavior to the self-managed cluster.

User Story
As a user I would like to create managed AKS clusters in Germany/China/USGovernment cloud environments.

Detailed Description
It looks like support for AzureEnvironment was done in self-managed clusters and hardcoded to the empty string defaults in the AKS code paths. The code changes would allow access to all the environments offered by Azure.

Contract changes [optional]

[Describe contract changes between Cluster API Azure Provider controllers, if applicable.]

Data model changes [optional]
Will probably add an AzureEnvironment to azuremanagedcluster identical to the one in azurecluster

/kind proposal

@k8s-ci-robot k8s-ci-robot added the kind/proposal Issues or PRs related to proposals. label Apr 27, 2023
@luthermonson
Copy link
Contributor Author

I am already working on a PR for this and the issue is to get attention of maintainers to figure out if I'm misguided in the change. It appears straight forward and I'm testing the idea in a fork we maintain of CAPZ and have a govcloud account to test in. I'll confirm everything is functional and submit a PR when I feel confident.

@dtzar dtzar added area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/feature Categorizes issue or PR as related to a new feature. labels May 2, 2023
@dtzar dtzar moved this to In Progress in CAPZ Planning May 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CAPZ Planning May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/feature Categorizes issue or PR as related to a new feature. kind/proposal Issues or PRs related to proposals.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants