Skip to content

Commit 0d44e5f

Browse files
committed
cluster: set v1beta2 Paused condition
1 parent 0e2128b commit 0d44e5f

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

internal/controllers/cluster/cluster_controller.go

+4-8
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ import (
4545
"sigs.k8s.io/cluster-api/feature"
4646
"sigs.k8s.io/cluster-api/internal/hooks"
4747
"sigs.k8s.io/cluster-api/util"
48-
"sigs.k8s.io/cluster-api/util/annotations"
4948
"sigs.k8s.io/cluster-api/util/collections"
5049
"sigs.k8s.io/cluster-api/util/conditions"
5150
"sigs.k8s.io/cluster-api/util/finalizers"
5251
"sigs.k8s.io/cluster-api/util/patch"
52+
"sigs.k8s.io/cluster-api/util/paused"
5353
"sigs.k8s.io/cluster-api/util/predicates"
5454
)
5555

@@ -89,7 +89,7 @@ func (r *Reconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager, opt
8989
handler.EnqueueRequestsFromMapFunc(r.controlPlaneMachineToCluster),
9090
).
9191
WithOptions(options).
92-
WithEventFilter(predicates.ResourceNotPausedAndHasFilterLabel(mgr.GetScheme(), predicateLog, r.WatchFilterValue)).
92+
WithEventFilter(predicates.ResourceHasFilterLabel(mgr.GetScheme(), predicateLog, r.WatchFilterValue)).
9393
Build(r)
9494

9595
if err != nil {
@@ -106,8 +106,6 @@ func (r *Reconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager, opt
106106
}
107107

108108
func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Result, reterr error) {
109-
log := ctrl.LoggerFrom(ctx)
110-
111109
// Fetch the Cluster instance.
112110
cluster := &clusterv1.Cluster{}
113111
if err := r.Client.Get(ctx, req.NamespacedName, cluster); err != nil {
@@ -126,10 +124,8 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
126124
return ctrl.Result{}, err
127125
}
128126

129-
// Return early if the object or Cluster is paused.
130-
if annotations.IsPaused(cluster, cluster) {
131-
log.Info("Reconciliation is paused for this object")
132-
return ctrl.Result{}, nil
127+
if isPaused, conditionChanged, err := paused.EnsurePausedCondition(ctx, r.Client, cluster, cluster); err != nil || isPaused || conditionChanged {
128+
return ctrl.Result{}, err
133129
}
134130

135131
// Initialize the patch helper.

0 commit comments

Comments
 (0)