Merge pull request #11341 from sbueringer/pr-drop-reconciler-events

🌱 Drop ReconcileError events

Author: k8s-ci-robot

internal/controllers/machinehealthcheck/machinehealthcheck_controller.go

@@ -182,7 +182,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
 			log.V(5).Info("Requeuing because connection to the workload cluster is down")
 			return ctrl.Result{RequeueAfter: time.Minute}, nil
 		}
-		r.recorder.Eventf(m, corev1.EventTypeWarning, "ReconcileError", "%v", err)
 
 		// Requeue immediately if any errors occurred
 		return ctrl.Result{}, err

internal/controllers/machineset/machineset_controller.go

@@ -256,7 +256,6 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (retres ct
 			return ctrl.Result{RequeueAfter: time.Minute}, nil
 		}
 		err = kerr
-		r.recorder.Eventf(s.machineSet, corev1.EventTypeWarning, "ReconcileError", "%v", kerr)
 	}
 	return result, err
 }

internal/controllers/machineset/machineset_controller_test.go

@@ -613,30 +613,6 @@ func TestMachineSetReconcile(t *testing.T) {
 		g.Expect(result).To(BeComparableTo(reconcile.Result{}))
 	})
 
-	t.Run("records event if reconcile fails", func(t *testing.T) {
-		g := NewWithT(t)
-
-		ms := newMachineSet("machineset1", testClusterName, int32(0))
-		ms.Spec.Template.Spec.Bootstrap.ConfigRef = &corev1.ObjectReference{
-			Kind:      "FooTemplate",
-			Namespace: ms.GetNamespace(),
-			Name:      "doesnotexist",
-		}
-
-		request := reconcile.Request{
-			NamespacedName: util.ObjectKey(ms),
-		}
-
-		rec := record.NewFakeRecorder(32)
-		c := fake.NewClientBuilder().WithObjects(testCluster, ms).WithStatusSubresource(&clusterv1.MachineSet{}).Build()
-		msr := &Reconciler{
-			Client:   c,
-			recorder: rec,
-		}
-		_, _ = msr.Reconcile(ctx, request)
-		g.Eventually(rec.Events).Should(Receive())
-	})
-
 	t.Run("reconcile successfully when labels are missing", func(t *testing.T) {
 		g := NewWithT(t)