Skip to content

Commit 21118ae

Browse files
committed
cluster: set v1beta2 Paused condition
1 parent b3cd56e commit 21118ae

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

internal/controllers/cluster/cluster_controller.go

+3-10
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,11 @@ import (
4545
"sigs.k8s.io/cluster-api/feature"
4646
"sigs.k8s.io/cluster-api/internal/hooks"
4747
"sigs.k8s.io/cluster-api/util"
48-
"sigs.k8s.io/cluster-api/util/annotations"
4948
"sigs.k8s.io/cluster-api/util/collections"
5049
"sigs.k8s.io/cluster-api/util/conditions"
5150
"sigs.k8s.io/cluster-api/util/finalizers"
5251
"sigs.k8s.io/cluster-api/util/patch"
53-
"sigs.k8s.io/cluster-api/util/predicates"
52+
"sigs.k8s.io/cluster-api/util/paused"
5453
)
5554

5655
const (
@@ -81,15 +80,13 @@ type Reconciler struct {
8180
}
8281

8382
func (r *Reconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager, options controller.Options) error {
84-
predicateLog := ctrl.LoggerFrom(ctx).WithValues("controller", "cluster")
8583
c, err := ctrl.NewControllerManagedBy(mgr).
8684
For(&clusterv1.Cluster{}).
8785
Watches(
8886
&clusterv1.Machine{},
8987
handler.EnqueueRequestsFromMapFunc(r.controlPlaneMachineToCluster),
9088
).
9189
WithOptions(options).
92-
WithEventFilter(predicates.ResourceNotPausedAndHasFilterLabel(mgr.GetScheme(), predicateLog, r.WatchFilterValue)).
9390
Build(r)
9491

9592
if err != nil {
@@ -106,8 +103,6 @@ func (r *Reconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager, opt
106103
}
107104

108105
func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Result, reterr error) {
109-
log := ctrl.LoggerFrom(ctx)
110-
111106
// Fetch the Cluster instance.
112107
cluster := &clusterv1.Cluster{}
113108
if err := r.Client.Get(ctx, req.NamespacedName, cluster); err != nil {
@@ -126,10 +121,8 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
126121
return ctrl.Result{}, err
127122
}
128123

129-
// Return early if the object or Cluster is paused.
130-
if annotations.IsPaused(cluster, cluster) {
131-
log.Info("Reconciliation is paused for this object")
132-
return ctrl.Result{}, nil
124+
if isPaused, conditionChanged, err := paused.EnsurePausedCondition(ctx, r.Client, cluster, cluster); err != nil || isPaused || conditionChanged {
125+
return ctrl.Result{}, err
133126
}
134127

135128
// Initialize the patch helper.

0 commit comments

Comments
 (0)