Skip to content

Commit 2ea822c

Browse files
committed
Remove deprecated index ByClusterClassName, ClusterByClusterClassClassName and ClusterClassNameField
Signed-off-by: Stefan Büringer [email protected]
1 parent 2cef1f0 commit 2ea822c

File tree

2 files changed

+2
-33
lines changed

2 files changed

+2
-33
lines changed

api/core/v1beta2/index/cluster.go

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ import (
2828
)
2929

3030
const (
31-
// ClusterClassNameField is used by the Cluster controller to index Clusters by ClusterClass name.
32-
//
33-
// Deprecated: This constant will be removed in an upcoming release, please use ClusterClassRefPath instead.
34-
ClusterClassNameField = "spec.topology.class"
35-
3631
// ClusterClassRefPath is used by the Cluster controller to index Clusters by ClusterClass name and namespace.
3732
ClusterClassRefPath = "spec.topology.classRef"
3833

@@ -69,31 +64,3 @@ func ClusterByClusterClassRef(o client.Object) []string {
6964
func ClusterClassRef(cc *clusterv1.ClusterClass) string {
7065
return fmt.Sprintf(clusterClassRefFmt, cc.GetNamespace(), cc.GetName())
7166
}
72-
73-
// ByClusterClassName adds the cluster class name index to the
74-
// managers cache.
75-
//
76-
// Deprecated: This func will be removed in an upcoming release, please use ByClusterClassRef instead.
77-
func ByClusterClassName(ctx context.Context, mgr ctrl.Manager) error {
78-
if err := mgr.GetCache().IndexField(ctx, &clusterv1.Cluster{},
79-
ClusterClassNameField,
80-
ClusterByClusterClassClassName,
81-
); err != nil {
82-
return errors.Wrap(err, "error setting index field")
83-
}
84-
return nil
85-
}
86-
87-
// ClusterByClusterClassClassName contains the logic to index Clusters by ClusterClass name.
88-
//
89-
// Deprecated: This func will be removed in an upcoming release, please use ClusterByClusterClassRef instead.
90-
func ClusterByClusterClassClassName(o client.Object) []string {
91-
cluster, ok := o.(*clusterv1.Cluster)
92-
if !ok {
93-
panic(fmt.Sprintf("Expected Cluster but got a %T", o))
94-
}
95-
if cluster.Spec.Topology != nil {
96-
return []string{cluster.GetClassKey().Name}
97-
}
98-
return nil
99-
}

docs/book/src/developer/providers/migrations/v1.10-to-v1.11.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ proposal because most of the changes described below are a consequence of the wo
102102
- `status.failureReason` and `status.failureMessage` will continue to exist temporarily under `status.deprecated.v1beta1`.
103103
- The const values for `Failed` phase has been deprecated in the enum type for `status.phase` (controllers are not setting this value anymore)
104104
- The `GetIPFamily` method (deprecated since CAPI v1.8) has been removed
105+
- The `index.ByClusterClassName`, `index.ClusterByClusterClassClassName` and `index.ClusterClassNameField` types have been removed
106+
in favor of `index.ByClusterClassRef`, `index.ClusterByClusterClassRef` and `index.ClusterClassRefPath`
105107

106108
### MachineDeployment
107109

0 commit comments

Comments
 (0)